Nico Weber

Per file compile flags and cwd

7

Incorporate the feedback from https://github.com/Rip-Rip/clang_complete/pull/29 From what I understand, libclang will either soon support or does already support passing in a current working directory instead of using getcwd(). Once that's...

smhasher: Set UNALIGNED_SAFE for 64-bit intel too.

1

This is better for perf, and also happens to suppress a new clang warning: PMurHash.c(209,12): error: cast to smaller integer type 'long' from 'const unsigned char *' is a Microsoft...

I ran: N=10 ( for f in $(git ls-files '*.png'); do ((i=i%N)); ((i++==0)) && wait ~/src/zopfli/zopflipng -ym $f $f & done ) zopflipng only overwrites a file if the new...

knn classify method in ch08 isn't quite right

1

It computes a label -> vote mapping and then ignores the votes and just returns the highest label. The change to knn.py in https://github.com/nico/cvbook/commit/bf567d293e3620538c5e0e3b2af580a2cc28db56 fixes this.

Example 7.5 is wrong

1

This fixes it: https://github.com/nico/cvbook/commit/b76fdbc1d5944bcdf8f3a67c94390f1ddccef73a#diff-d41d8cd98f00b204e9800998ecf8427e

Since you're accepting pull requests, here's another one :-) Your ch3_panorama.py took more than 8 minutes to run (after which I killed it). My version runs in 3 seconds. This...

See commit https://github.com/nico/cvbook/commit/102a8b098664cfff1f5be85fbd0de9fd72d1b8e2 – the arguments to `F_from_ransac()` need to be swapped. You don't have this example in your repo, so no pull request. I tried this with the two...

(do not merge) Tests: Add test for loading a broken image

1

Want to see if CI can catch #19141 with this.