Nico Weber
Nico Weber
That's already kinda the setup -- the main binary is all of 187 lines. What concretely would you change?
> @nico would you be willing to take a look? I see you helped review the `cat -n` PR #24382 CI is currently red. Can you get that sorted out...
What happens in other terminals when you copy concealed text? Does it make it to the clipboard?
"When painting a concealed cell, paint it with `bg` as foreground color instead of with the current foreground color" seems like an elegant approach to me! Do you think that...
> > They set the bg and fg to the same colour. I guess that works 🤷♂️ > > That depends on what you mean by colour. I've noticed that...
No, good as-is. Thanks for checking, and for the discussion everyone!
Oh, and thanks for the patch too of course :)
(you can add a line to https://github.com/SerenityOS/serenity/blob/master/.mailmap to map that email to your GitHub-associated emails. Or you can add that email to your GitHub profile emails.)
More tests is cool. Saving allocations if it's in service of some other goal (measurably better perf, as part of a project for better memory handling in the kernel, or...
I'd happily merge the test 🙂 I'm not sure if the fewer allocations are worth the extra code. Even if it's many allocations for very large files, it's probably still...