Nico Weber

Hi, On 01.05.2011, at 13:54, Silex wrote: > Where are we about this pull request? Seems there's a lot of unresolved questions... is the code here something Rip-Rip should consider...

I'd like to reopen this. In Chormium, we now use the [ninja](http://martine.github.com/ninja/) build system, which can hand out compile flags for given files _very_ quickly. So if something like this...

See https://bugs.chromium.org/p/chromium/issues/detail?id=1175933#c8 for a fix suggestion that might be better.

> See https://bugs.chromium.org/p/chromium/issues/detail?id=1175933#c8 for a fix suggestion that might be better. We went with that change in chromium's downstream version, see https://chromium.googlesource.com/chromium/src/+/05a80c4f3d18994cb411ae01b97bc97b327272e7%5E%21/#F3 Please consider merging this change upstream.

I forgot about amd64; we'll have to patch the warning in the unaligned branch for that. But this seems like a good change regardless.

This was fixed either Oct 11 2019 or Dec 16 2019 (https://bugs.chromium.org/p/chromium/issues/detail?id=989095#c19).

Very cool! Conceptually, I'd: * Make the "does app support multires" opt-out, not opt-in (gives us a burn down list right in the source) * not pass in a scale...

Embedding git revisions in binaries means that two identical source trees except for a comment change somewhere produce different binaries. The cool way to handle this is to have deterministic...

> it's basically meaningless, compared to being able to trace a build back to a specific commit in the serenity repo. Au contraire! If your build is deterministic, the output...

I found https://developercommunity.visualstudio.com/content/problem/502528/changing-pdb-source-file-paths-with-experimentalde.html which says: """PDBs are not deterministic and aren't the intended target of this feature, so there may still be a great many full paths still embedded in...