serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Browser: Popup menu in stylesheet inspector doesn't work

Open nico opened this issue 1 year ago • 1 comments

We'll probably need something like https://github.com/SerenityOS/serenity/commit/549f5fe374a7713762b76a80a4645dfe80d1c643 for Userland/Applications/Browser too. Tab.{h,cpp} currently has RefPtr<GUI::Menu> m_select_dropdown and that has to move to the view impl.

However, as far as I can tell, that's currently LibWebView/OutOfProcessWebView, and that probably shouldn't have access to LibGUI (?).

nico avatar Nov 16 '24 14:11 nico

OutOfProcessWebView already depends on LibGUI, so short term putting it there looks like the clear path forward.

nico avatar Dec 03 '24 14:12 nico