nickolas-deboom

Results 33 comments of nickolas-deboom

The update made in 82c59e6b24dc3e4fd77bfd1fd2e17ed6d20ffedb uses subscriptions for the temp range limits rather than reading them during init. This change was made to resolve an issue with InteractionQueueFull exceptions seen...

> This looks good, just add the unit test for if RPC version < 4 that you did for matter-thermostat ([4c9707b](https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/commit/4c9707b7c23b9fbbfe370a4ab591bc9c68774041)) and I'll approve this! This unit test was added...

Please note that these changes have not been tested yet and will need test case updates before closing.

These changes were tested using an IKEA Vindstyrka Air Quality Sensor and Dirigera Hub, joined to a v3 hub via a matter bridge, and verifying that the Vindstyrka device joins...

The update made in cf3d46dee6736fb1545a771e32ab5b6760b304fc uses subscriptions for the temp range and setpoint range limits rather than reading them during init. This change was made to resolve an issue with...

> we need a fingerprint for the device 👍 I forgot to respond but I added one!

Hi @DongHoon-Ryu I went over the changes and left some comments. Outside of that, the changes look good to me!

Unrelated to the changes in this PR but all instances of `OFF_ON_AUTO` in `matter-thermostat/src/init.lua` should be changed to `OFF_HIGH_AUTO`

> Unrelated to the changes in this PR but all instances of `OFF_ON_AUTO` in `matter-thermostat/src/init.lua` should be changed to `OFF_HIGH_AUTO` This has been fixed.

> @nickolas-deboom can we get the unit test coverage for extractor-hood above 90%? > /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-extractor-hood/init.lua 76% ❌ Done!