Implement Flow Sensor device type
Type of Change
- [ ] WWST Certification Request
- If this is your first time contributing code:
- [ ] I have reviewed the README.md file
- [ ] I have reviewed the CODE_OF_CONDUCT.md file
- [ ] I have signed the CLA
- [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
- If this is your first time contributing code:
- [ ] Bug fix
- [x] New feature
- [ ] Refactor
Checklist
- [x] I have performed a self-review of my code
- [x] I have commented my code in hard-to-understand areas
- [x] I have verified my changes by testing with a device or have communicated a plan for testing
- [x] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior
Description of Change
This change adds support for the Flow Sensor device type. This device type was added to matter spec a while ago but has not been implemented into our platform yet.
This PR shouldn't be merged until the tickets listed on this page are complete.
Summary of Completed Tests
New unit tests were implemented to verify the cluster -> capability mappings. Note that there are not any existing matter flow sensors yet, and there is not a virtual flow sensor device in the VDA, so we can't test this on a real device at this time.
Duplicate profile check: Passed - no duplicate profiles detected.
Test Results
66 files ±0 421 suites +1 0s ⏱️ ±0s 2 166 tests +2 2 166 ✅ +2 0 💤 ±0 0 ❌ ±0 3 688 runs +3 3 688 ✅ +3 0 💤 ±0 0 ❌ ±0
Results for commit 1d8c8971. ± Comparison against base commit 7397af4a.
:recycle: This comment has been updated with latest results.
| File | Coverage | |
|---|---|---|
| All files | 87% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua | 91% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua | 45% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua | 92% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua | 83% |
:x: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against 1d8c8971dad4625161cd057adb7bdb02ea516e69
we need a fingerprint for the device :+1:
we need a fingerprint for the device 👍
I forgot to respond but I added one!
Channel deleted.