nickolas-deboom

Results 33 comments of nickolas-deboom

Closing as no longer needed with profile limit increase.

> It looks like this PR has 2 commits, one of which ([5e98aad](https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1549/commits/5e98aad12370d2802f5efc358a12e0212d5eccc9)) seems to already be included in #1547 > > Could you rebase and remove the first commit...

> I'm a little confused to the functionality being added here. So the title states "subscribe to child device attributes", but this subscription logic is being added in init, not...

> LGTM! I left just one nit to be fixed before merging. Also could you fill out the summary of completed tests section of the PR comment template? Then I...

I tested this with the VDA and it looks good except the operational state is not updating (it always says Stopped). I think this is an issue with the VDA...

Hi @HunsupJung , the changes look good to me. I also tested them with the VDA and everything is working great. I'm not certain but it appears that this even...

> @nickolas-deboom I don't think this PR is just for the VDA, I think it is for the Mamaba window covering device, and the VDA happens to have similar behaviors...

> What testing have you done to make sure that things are still working correctly? Hey Harrison, I realized that I never responded to your comment, but I updated the...