Matter Bridge Aqara Cube Support with Custom Capability
Currently, the Generic EdgeDriver applied to the Matter Bridge Aqara Cube is implemented by mapping six faces into individual components, making it difficult to check the event occurrence of individual faces on one screen.
This commit wants to improve the problem by mapping the event from Matter Bridge with Aqara Cube Custom Capability developed by Zigbee driver. This means that there is a limitation that the Action Event of the Cube that the Matter Bridge does not give can not be processed.
REQ-15926, REQ-16285, IOTE-4217, IOTE-4266
Check all that apply
Type of Change
- [ ] WWST Certification Request
- If this is your first time contributing code:
- [ ] I have reviewed the README.md file
- [ ] I have reviewed the CODE_OF_CONDUCT.md file
- [ ] I have signed the CLA
- [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
- If this is your first time contributing code:
- [ ] Bug fix
- [ ] New feature
- [x] Refactor
Checklist
- [x] I have performed a self-review of my code
- [x] I have commented my code in hard-to-understand areas
- [x] I have verified my changes by testing with a device or have communicated a plan for testing
- [x] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior
Description of Change
This commit wants to improve the problem by mapping the event from Matter Bridge with Aqara Cube Custom Capability developed by Zigbee driver. This means that there is a limitation that the Action Event of the Cube that the Matter Bridge does not give can not be processed.
Summary of Completed Tests
- Successful test for Plugin UI update and Dash Board's Device Card status update according to the selection of each face
- Successful Automation Routine Test for Cube Face
- Even though the Cube Face is changed, the status is sometimes not updated because the Aqara Matter Bride does not send the event.
Duplicate profile check: Passed - no duplicate profiles detected.
Test Results
63 files 396 suites 0s :stopwatch: 1 936 tests 1 936 :white_check_mark: 0 :zzz: 0 :x: 3 360 runs 3 360 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 54c26816.
:recycle: This comment has been updated with latest results.
| File | Coverage | |
|---|---|---|
| All files | 93% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua | 38% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua | 96% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua | 91% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua | 91% |
:white_check_mark: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against 54c26816c1b4e715f1c3a3a76b7bab4a61af1cb5
Hi @DongHoon-Ryu I went over the changes and left some comments. Outside of that, the changes look good to me!
Channel deleted.
Just a reminder @DongHoon-Ryu, please squash your commits before merging into main. Thank you very much.