nickolas-deboom

Results 33 comments of nickolas-deboom

After some discussion with the team, we realized that the logic in matter-oven to emit the capabilities with degF would allow the proper temperature units to display for hubs that...

> I left some comments but I do not think they are anything that should block moving forward with the beta release next week. Consider this my approval pending resolution...

Hi @HunsupJung , I agree with these changes, however I have a PR [here](https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1619) that implements dynamic constraints for matter-thermostat and matter-sensor that does many of the same things as...

> Hi @HunsupJung , I agree with these changes, however I have a PR [here](https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1619) that implements dynamic constraints for matter-thermostat and matter-sensor that does many of the same things...

I left one comment but other than that the changes look great! Thanks for making the update.

Closing in favor of https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1663

> I left a few more small comments but this is my final review and I think it's ready. Has this also been regression tested with some of the switch/button...

@hcarter-775 , I decided to move the remaining button functionality (helper functions, handlers, etc) to `buttons.lua` because I thought it was a bit confusing to have a `buttons.lua` but only...

These changes look pretty straightforward. I was trying to trace through the logic for the following sequence, does this look right to you? I think this matches scenario (2) you...