SmartThingsCommunity
Matter Sensor: Temp limits dynamic constraints
Subscribe to the temperature limit attributes and set capability constraint based on the limits.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Test Results
57 files 369 suites 0s :stopwatch: 1 787 tests 1 787 :white_check_mark: 0 :zzz: 0 :x: 3 103 runs 3 103 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 34b6df4a.
:recycle: This comment has been updated with latest results.
| File | Coverage | |
|---|---|---|
| All files | 85% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua | 94% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/attributes/init.lua | 94% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/attributes/MeasuredValue.lua | 90% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/types/Feature.lua | 66% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/commands/init.lua | 57% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/init.lua | 71% |
:x: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against 34b6df4ae5870703f0d75137fdd9c0c81c9ba9a2
The update made in 82c59e6b24dc3e4fd77bfd1fd2e17ed6d20ffedb uses subscriptions for the temp range limits rather than reading them during init. This change was made to resolve an issue with InteractionQueueFull exceptions seen while onboarding a large number of devices at the same time.
This looks good, just add the unit test for if RPC version < 4 that you did for matter-thermostat (4c9707b) and I'll approve this!
This unit test was added here: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1224/files#diff-915816924e061c2f6111072dae683786dc77bf79e5e5b37df1dfb2bed732afa5