Mohammed Al Sahaf

Results 250 comments of Mohammed Al Sahaf

> I saw the metrics before in v2.8.4. Things like `go_info`, `go_goroutines`, `go_threads`, `go_gc_duration_seconds` or `process_cpu_seconds_total`. Maybe before the default registry was used so these 2 were always registered via...

> @mohammed90 can you try this? This works! See mohammed90/caddy-git-fs#2. I had to introduce a local interface to reach the `Unwrap` method, and this is alright. > when i run...

> hi can I work on this? Can you please share your implementation plan?

Thanks for the hint. I found this in stdlib code: https://github.com/golang/go/blob/6d89b38ed86e0bfa0ddaba08dc4071e6bb300eea/src/net/http/transport.go#L1727-L1728 It appears that Go stdlib overwrites the value here. Tracking and fixing this might be tricky.

It's actually doable using the JSON config. See [here](https://caddyserver.com/docs/json/apps/tls/), you can enable `on_demand` on a specific automation policy, which includes specifying the issuer.

The admin endpoint doesn't take requests from the public secure port, i.e. 443. It only takes requests from the remote admin endpoint. You have to configure [`listen`](https://caddyserver.com/docs/json/admin/remote/). This is a...

But the remote admin endpoints isn't in your configuration. If there's something missing, please share full details without redaction.

Thank you for the investigation! Please feel free to send the PR, @Compy, even if you feel it's hacky. We can iterate on it.

> My build script, which installs `xcaddy@latest` is just running into issues since v0.4.3 release and the caddy build fails with this error: > > ``` > 2024/11/05 22:55:34 [INFO]...