caddy icon indicating copy to clipboard operation
caddy copied to clipboard

filesystem changes

Open elee1766 opened this issue 1 year ago • 5 comments

elee1766 avatar Jul 21 '24 18:07 elee1766

@mohammed90 can you try this?

when i run caddyfile adapt, i get

{
"apps": {
filesystems: {filesystems: [{"name":"foo","files_system":{...}}
//...

not sure if this is right still.

elee1766 avatar Jul 21 '24 18:07 elee1766

note for myself: notify these projects

https://github.com/sagikazarmark/caddy-fs-s3 https://github.com/tecosaur/caddy-fs-git

elee1766 avatar Jul 21 '24 18:07 elee1766

@mohammed90 can you try this?

This works! See mohammed90/caddy-git-fs#2. I had to introduce a local interface to reach the Unwrap method, and this is alright.

when i run caddyfile adapt, i get

{
"apps": {
filesystems: {filesystems: [{"name":"foo","files_system":{...}}
//...

not sure if this is right still.

I wonder if it's possible to reduce the nesting. In other words, to make it:

{
    "apps": {
        filesystems: {
            "foo": {
                    // filesystem stuff...
                    "backend": "fs_backend_module" ...
            },
            "bar": {
                    // filesystem stuff...
                    "backend": "fs_backend_module" ...
            }
        }

or if necessary at all 🤔

mohammed90 avatar Aug 03 '24 17:08 mohammed90

Nit, but should it be file_systems? (Since it's two words)

mholt avatar Aug 05 '24 13:08 mholt

Nit, but should it be file_systems? (Since it's two words)

https://caddyserver.com/docs/caddyfile/options#storage

dont think it's a nit, i think you're right, you already use file_system elsewhere in the project. will change soon

elee1766 avatar Aug 05 '24 20:08 elee1766