Mohammed Al Sahaf
Mohammed Al Sahaf
I wonder if the issue is the `metricsHandler` field is nil for some reason 🤔 https://github.com/caddyserver/caddy/blob/fb22a26b1a08a2fa3b2526d1852467904ee140f6/modules/metrics/adminmetrics.go#L65
Ideally, we need to be able to reproduce the bug _in the most minimal way possible_. This allows us to write regression tests to verify the fix is working. If...
Yes, since we're blocked with import cycle, we can revert to stdlib log.
We need to update our usage of `cosign` before merging this, otherwise the release flow will fail. Reference: sigstore/cosign#4354
Can you elaborate on this? > but not every system and environment allows for this. In a critical infra as you describe, the DNS resolvers in your infra should be...
Honestly, this makes me more inclined to make the resolver a module rather than pulling more deps and add more code to support cases where someone doesn't the resolver in...
Fix description by GitHub Copilot (Clause Sonnet 4): # Memory Bloat Fix - Analysis and Solution ## Problem Summary Memory bloat was introduced in commit `0e1579f1adc7c94f16852531c1c3658752c2e3d8` which attempted to fix...
I think this kind of feature is better implemented in a `listener_wrapper` rather than an HTTP handler.
> The benefit of it being an HTTP handler is it can respond with an HTTP 429. Good point
Can you share more log lines and the full config? Ideally, we need to be able to reproduce the bug _in the most minimal way possible_. This allows us to...