Mohammed Al Sahaf

Results 250 comments of Mohammed Al Sahaf

I'm confident it isn't Caddy server doing it because we don't do checks for updates. You censored the `remote_ip`, which is the IP address of the client calling your server,...

> The IP is 159.65.99.124, which WHOIS shows is owned by DigitialOcean, on which caddyserver.com is also hosted. Hmm, yeah, that's our server. We'll investigate.

> Hi, can i work on this? Can you please share your implementation plan?

It works, just slow. Give it a minute. It took around 1 minute for me.

> it doesn't seem obviously \"out of scope\" to me to have the inverse functionality Easier said than done. There's no canonical translation from JSON to Caddyfile. The translation from...

There's #6506 as PoC, but it might need refinement in terms of experience.

> [@mohammed90](https://github.com/mohammed90) I'm now reconsidering this. I don't think we should count them as normal config modules (because they are not). Maybe we should rip out the linked code (if...

> POST with your Content-Type that you want to use Not sure if you remember, but you implemented support for `Content-Type: text/`. I like the `HEAD` idea. I still think...

> if your preferred adapter is supported, you can try POSTing with it to begin with, instead of always doing a HEAD first. That feels wrong. The HEAD idea is...

No reason other than it's left-over from the early days when `client_ip` wasn't a thing. PR is welcome if you beat us to it.