Mohammed Al Sahaf

Results 250 comments of Mohammed Al Sahaf

I don't understand. We use `ProxyFromEnvironment` if the `ForwardProxyURL` is not set: https://github.com/caddyserver/caddy/blob/4ade967005929e98ae2265d9d7c89b33f1ca951b/modules/caddyhttp/reverseproxy/httptransport.go#L330-L339 I apparently have a related draft PR that I've forgotten (#6399), but not 100% if it's helpful...

I guess my PR could include a proxy provider `"from": "none"` 🤔

My knowledge of running Python apps, especially Flask, is minimal. I have followed the instructions, and I also run `pip install -r requirements.txt` to ensure all requirements are installed. However,...

Actually I'm considering using Cobra. That requires extensive effort to retrofit.

> I swapped out my cache ttl from `ttl 28d` to `ttl 2419200s` and it's worked for what it's worth. Souin uses the `time.Duration` type from Go standard library. This...

I put this together as PoC in response to https://github.com/caddyserver/caddy/pull/6504#issuecomment-2281492551. I don't know if it's the best approach or not. It's an experiment.

Keep in mind, those gosec workarounds won't be needed once their bug is fixed. https://github.com/securego/gosec/issues/1187

> I don't fully understand the metrics aspects, but if this works, that's big if true, yeah? There may be a small uptick in memory utilization, but should be negligible...

> I'm checking out the 2.9.0 beta and I noticed that there aren't any of the Go or process metrics exposed (`collectors.NewProcessCollector`, `collectors.NewProcessCollector` from `github.com/prometheus/client_golang/prometheus/collectors`). Is that intended? Should the...