Mohammed Al Sahaf
Mohammed Al Sahaf
Moreover, since this impacts `remote_ip`, please do not redact the field in the log line. We need to know the structure of the IP address with which it fails.
> > Can you craft a minimally reproducible example? You have a bunch of redactions which make it hard to confirm what's going on. > > I'll look into that....
> I have opened issues upstream: > > * https://discuss.dgraph.io/t/build-failure-for-goos-solaris-illumos-plan9/9145?u=mholt > > * [etcd-io/bbolt#231](https://github.com/etcd-io/bbolt/issues/231) > > * [chzyer/readline#188](https://github.com/chzyer/readline/issues/188) > > > I've also removed those platforms from our download page...
The single-dash flags seem to be already used and referenced across the interwebs, examples: - https://wiki.archlinux.org/title/Caddy - https://mercure.rocks/docs/hub/install - https://www.booleanworld.com/host-website-caddy-web-server-linux/ This PR introduces a breaking change to the CLI. Scripts...
> Thanks for working on this Mohammed. It's been a while since I looked at the manpages thing; is the main advantage of this approach over [caddyserver/dist#73](https://github.com/caddyserver/dist/pull/73) the support for...
As of [Cobra v1.4.0](https://github.com/spf13/cobra/releases/tag/v1.4.0), there is not dependency on Viper, which thins its dependency to minimum and matches coral, so swapping coral for cobra does not introduce any new deps...
I guess it's ready for review now. I hope I didn't miss anything!
> @francislavoie @mohammed90 what if we have Caddy emit a warning if a wildcard domain is configured without the DNS challenge? Not too unreasonable. Should it be just warning though?...
Oh, I skimmed the RFC of ACME and found it mentions the order with DNS challenge _may_ set the `wildcard` field to `true`, but I didn't find the same notion...
> I have created [a server and a client](https://github.com/caddyserver/caddy/files/4903225/caddybug.tar.gz) to reproduce the bug. > > The attached archive contains a Java maven project together with a README file with detailed...