Mohammed Al Sahaf
Mohammed Al Sahaf
> Can I work on this?? > Describe what you'll do please
The `metrics` directive which goes inside site block isn't to configure metrics. It's to configure a handler that exposes metrics on the site. You also shouldn't need to list the...
> When you publish the plugin, can you document that `caddy upgrade` does not upgrade plugins? (unless I'm wrong about that) It will upgrade the plugins. Why wouldn't it? It's...
> Looking at the code and doing a test where I built Caddy with an outdated plugin and then ran the upgrade command led me to believe that the upgrade...
The code in the commit 07ad953 was written by [Amp](https://ampcode.com/). I have skimmed its changes, but I have to go back and read the whole thing. Here's its summary. ##...
The code in commit 7ac7ca3 is written by Amp as well. Here's the summary. Good! The code has been formatted and the race condition appears to be fixed. Let me...
I'll check later. I've used all my credit already lol
> And what do you think of the following suggestions: #7161 (comment) Please give it a shot
> I also don't like that they call it \"caddyserver\", that's not the name of the project, it's \"caddy\" and the \"server\" part was only necessary because the org and...
Matt is right, Cobra takes the name of the root command, which in our case is Caddy. https://github.com/spf13/cobra/blob/fc81d2003469e2a5c440306d04a6d82a54065979/completions.go#L824 I'm not sure how we could modularize it, from the top of...