François Mockers

Results 430 comments of François Mockers
trafficstars

I think it's an issue with newline characters on Windows

Could you rename the example (and everywhere it's mentioned) to "multiple sprites, one **parent** entity? Saying "one entity" is misleading otherwise

this wasn't supported because I didn't try sending the token in the body instead of a query parameter, which didn't work 👍 I pushed a fix that should do the...

I would be happy to review that PR 👍 I mostly used this for a CLI so never took the time to go async...

Should be fixed by #840, but I think you have to clean the cache of all examples you already loaded

all platforms need to look at this file, not just macos.

I think copying the file content in the markdown will be an extra place that's not kept in sync, I would prefer to have that in only one place. No...

when replacing an `unwrap` with an `expect`, the message should: - be helpful to understand why the panic happens - be written to target people who will see them: is...

this *should* be ready to be merged, but can't be unless we (temporarily) remove the job `run-examples-macos-metal` from the required checks: I needed to move it to a `pull_request_target` trigger...