bevy-website icon indicating copy to clipboard operation
bevy-website copied to clipboard

Improve LLD fast compile instructions

Open TrialDragon opened this issue 11 months ago • 3 comments

Adds relevant config file info for using LLD linker in Rust and Bevy to avoid confusion.

Closes #727

TrialDragon avatar Mar 06 '24 01:03 TrialDragon

all platforms need to look at this file, not just macos.

mockersf avatar Mar 06 '24 05:03 mockersf

~~I know that, it's why I'm not moving the entire thing up under MacOS; I'm simply adding a reference to point towards the appropriate smaller part of that file that is relevant to MacOS usage of LLD so as to avoid the confusion the original issue / discussion had where users may not realize there is more needed to get LLD working for MacOS.~~

Edit: On second thought, there is a better solution, and was what was recommended in the original discussion but I misinterpreted, sorry.

TrialDragon avatar Mar 06 '24 06:03 TrialDragon

I think copying the file content in the markdown will be an extra place that's not kept in sync, I would prefer to have that in only one place. No strong opinion though if it should be in the Bevy repo or in the website

mockersf avatar Mar 07 '24 21:03 mockersf

It may be worth taking a look at https://github.com/bevyengine/bevy/pull/13136, where I updated config_fast_builds.toml with far more documentation. If there's anything there that can be reused, feel free :)

BD103 avatar May 01 '24 23:05 BD103

@ickk I re-added S-Ready-For-Final-Review because Trial fixed the change requested. If you have another request, feel free to remove it again. Overall I'm happy with this PR, though. ✅

BD103 avatar May 05 '24 13:05 BD103

This should live here, but we should definitely work towards deduplicating this.

alice-i-cecile avatar May 13 '24 17:05 alice-i-cecile

I see this was merged already, but this advice for macOS is outdated. The new default linker on macOS is faster than lld, which is also why the macOS version of mold (called sold) is no longer a paid product.

msvbg avatar May 14 '24 00:05 msvbg

I see this was merged already, but this advice for macOS is outdated. The new default linker on macOS is faster than lld, which is also why the macOS version of mold (called sold) is no longer a paid product.

I created #1160. If you would like to open a pull request, feel free!

BD103 avatar May 14 '24 13:05 BD103

PR: https://github.com/bevyengine/bevy-website/pull/1161

msvbg avatar May 14 '24 13:05 msvbg