bevy
bevy copied to clipboard
bevyengine
Compare screenshots with main on PRs
Objective
- Compare screenshots for a few examples between PRs and main
Solution
- Send screenshots taken to a screenshot comparison service
- Not completely sure every thing will work at once, but it shouldn't break anything at least
- it needs a secret to work, I'll add it if enough people agree with this PR
- this PR doesn't change anything on the screenshot selection (load_gltf and breakout currently), this will need rendering folks input and can happen later
What happens when there's a failure? does ci just fail or are you able to see the diffs somewhere?
What happens when there's a failure? does ci just fail or are you able to see the diffs somewhere?
it should log an url like https://pixel-eagle.vleue.com/project/b25a040a-a980-4602-b90c-d480ab84076d/run/1335/compare/1327 that will let you see the issues
Maybe we should put the flight helmet into the lighting scene. Or just put together a test scene which has a whole bunch of features enabled all at once to catch differences.
Maybe we should put the flight helmet into the lighting scene. Or just put together a test scene which has a whole bunch of features enabled all at once to catch differences.
Since https://github.com/bevyengine/bevy/pull/11904, the flight helmet makes rendering crash in CI on Windows
@mockersf I'm happy to merge this: looks like it needs you to add a secret first?
this should be ready to be merged, but can't be unless we (temporarily) remove the job run-examples-macos-metal from the required checks: I needed to move it to a pull_request_target trigger for it to be able to access secrets, which means it runs from its definition on the base branch of the PR, and this job in this workflow doesn't exist yet there
removed the required check, merged the pr, added the required check back, notice the screenshot upload failed 😭 https://github.com/bevyengine/bevy/pull/15894 should fix it