Moritz Firsching
Moritz Firsching
> Interesting. It seems the libjxl pipelines succeeded at the time of upgrade. I'm curious what caused it to change - perhaps a compiler update? Actually, "Build/Test / Windows MSYS2...
> It seems the "passing" tests were build-only, not actually running those tests? Yes, exactly.
There are also asan failures with emu128: ``` Note: Google Test filter = ConvolveTestGroup/ConvolveTest.TestConvolve/Emu128 [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test...
> Interesting. It seems the libjxl pipelines succeeded at the time of upgrade. I'm curious what caused it to change - perhaps a compiler update? > > When running on...
> hm, it might indeed be a compiler issue. I see both convolve_test and mul_test working with ci.sh asan (clang 13). What's running on the builder is clang-7. I see...
I hope this can be closed when `0.7` is released...
We should decide on this before version 1.0
I added the PATCH_VERSION and a slighly different JPEGXL_NUMERIC_VERSION. Any thoughts, @veluca93 @szabadka @eustas?
@tbonfort @novomesk @dlemstra this also aims at closing #1721
> The comment still mentions `JPEGXL_COMPUTE_LIBRARY_VERSION`? Might also be nice to add this and update the comment to also include the patch version? And also use `JPEGXL_COMPUTE_NUMERIC_VERSION` in the comment...