Moritz Firsching

Results 226 comments of Moritz Firsching

> sorry, but I don't know how to do this. Since nothing happened here for a long time, I left this problem. Please visit https://cla.developers.google.com/. Once you've signed, follow the...

Possibly related: https://github.com/libjxl/libjxl/issues/1704

Can this be merged, @sboukortt?

Trying to repo this. On linux the cjxl command you are tying to run seems to work: ``` ~/libjxl ((v0.6.1))> identify sample.png sample.png PNG 7593x5062 7593x5062+0+0 16-bit sRGB 198.656MiB 0.000u...

This looks like you are using a binary build with commit a205468. Perhaps you could try the executables from a more recent build, e.g. https://github.com/libjxl/libjxl/actions/runs/2219055596 to see if the problem...

> Same error with JPEG XL encoder v0.7.0 [10d7a7d](https://github.com/libjxl/libjxl/commit/10d7a7d15e638102f70ff57f248fcf92babc69bc) from [jxl-x86-windows-static](https://github.com/libjxl/libjxl/suites/6244749736/artifacts/222003593). > > ``` > PS C:\> ."C:\Local\Tools\libjxl_x86\cjxl.exe" "C:\temp\sample.png" "C:\temp\sample.png_x86.jxl" --num_threads 8 -v -v ; Write-Host -ForegroundColor Cyan $LASTEXITCODE >...

Could you provide the original jpg? With a slight modification, I could reconstruct the attached jpg. ![out](https://user-images.githubusercontent.com/3491627/167599146-ee15e23b-5f7d-4363-9e56-29140f7b0240.jpg)

Ok, so if I understand correctly, the .jxl you generated does not even contain the xmp-content anymore, right? In that case #1404 should be a sufficient fix, at least it...

To summarizes, the todo-items here are: - update 18181-2 to make clear such a bitstream is invalid. - refuse to decode such files

This seems potentially error prone, I'm not sure we should do it.