Moritz Firsching comments

Results 226 comments of


                                            Moritz Firsching

Compression 2022

I'd be happy to be a reviewer on this chapter!

cjxl -q 0 fails with "Setting frame distance failed"

Thanks for opening this issue! I can confirm the problem! This will trigger for any value for `-q` that is smaller than $-5\log_{2.5}(6.25 (25 - 6.4)) + 30 \approx 4.04894058712018289225062637746033...,$...

stage_upsampling.cc not building on MSVC 2019 (C4789 error claiming buffer overrun)

a possible workaround might be to make `ups` always length 8. ..or disable warning as error...

Invalid read of size 4 in jxl::PerformBlending

This was introduced by https://github.com/libjxl/libjxl/commit/a426a680. In https://github.com/libjxl/libjxl/blob/137f53ef1a6f39e5f733edb6cc457625abb3b3c9/lib/jxl/render_pipeline/stage_blending.cc#L146 there is a silent assumption that the size of `ec_bg` is the same as `bg_`. However in this fuzzer image, this is not...

Add codespace that use ubuntu and emsdk container.

LGTM, what do you think, @eustas?

version discrepancy between tag/tarball and version/library/pkg-config

I think this has been settled by #1757

Unclear support status for CMYK in v0.7

Is this mainly a documentation problem, or do we actually want to change behavior here?

Unclear support status for CMYK in v0.7

In some sense this is the encoder analogue to this decoder issue: https://github.com/libjxl/libjxl/issues/1542

At distance >= 20, v0.6.1 + kimageformats + Gwenview fail to properly render nightly's output

So, I guess this can be closed with the coming 0.7.0 release.

At distance >= 20, v0.6.1 + kimageformats + Gwenview fail to properly render nightly's output

> So, I guess this can be closed with the coming 0.7.0 release. Closing, because this is fixed in the 0.7.0 release