Moritz Firsching

Results 226 comments of Moritz Firsching

Just out of interest, how do you "reconverted to 8bits for visualization" in the original post? If I just do linear scaling assuming this is 11bit data it does not...

I assume this is now working with version 0.7.0

Is this still reproducible at the current head?

> FWIW, there seems to be one from pixbufloader (skcms related): https://github.com/msys2/MINGW-packages/actions/runs/3118427105/jobs/5057708500 > > ``` > In function 'D baseline::cast(const S&) [with D = __vector(4) float; S = __vector(4) short...

> > I kind of wonder how useful JxlDecoderSetPreferredColorProfile will still be if we have a function that can guarantee to give you output in the preferred space (which would...

Discussing this again gave the following conclusion (in contrast to the post just above): - Having `SetPreferredColorEncoding` and `JxlDecoderSetDesiredIntensityTarget` not working in all cases is a problem and make those...

I tried to reflect the discussed changes into the pull request, please take a look @jonsneyers (and @veluca93 @sboukortt @szabadka)

> Another question to consider: do we need to support decoding to an arbitrary ICC? I'd argue it is not fundamental for our API to allow it. What kind of...

The latest commits have been done together with @veluca93 and contain the following ideas: - merge together `JxlDecoderSetPreferredColorProfile` and `JxlDecoderSetICCProfile` as `JxlDecoderSetOutputColorProfile` order avoid having two functions to do very...

> LGTM as it is now, I wanted to approve but I cannot do that since I started this PR :) Cool, I approved it, you can merge it...