Moritz Firsching comments

Results 226 comments of


                                            Moritz Firsching

Set install_name properly when building brotli on macOS

Thanks for the patch, @tmkk! Could you sing the CLA (instruction in the message above from the google-cla bot ...)?

Set install_name properly when building brotli on macOS

Also you would need to add yourself to the [AUTHORS](https://github.com/libjxl/libjxl/blob/main/AUTHORS) file

Set install_name properly when building brotli on macOS

I rebased instead of merged to fix the authors check...

Decoding error in gimp when using modular with resampling

Thanks for the report! seems like this is related to https://github.com/libjxl/libjxl/issues/1755.

Decoding error in gimp when using modular with resampling

Considering #1755, it seems that you have been using an older version of libjxl. Could you try to check if the error persists at the current head?

Decoding error in gimp when using modular with resampling

I checked with current head, and it seems that the gimp plugin can decode the image flawlessly. Plesae reopen if this can be reproduced with the most recent version of...

tests: Make sure libjxl0.7 can still be found

https://github.com/libjxl/libjxl/pull/1717 was stuck because of the authors check and perhaps because it was cherry-picking too much.

The last version cjxl.exe can't turn jpg files to lossy jxl files.

Could you try with `--lossless_jpeg=0`, e.g. `R:\>cjxl.exe --lossless_jpeg=0 -q 80 R:\3.jpg 3.jxl`

The last version cjxl.exe can't turn jpg files to lossy jxl files.

@brucekiller thanks for bringing this up. If I recall correctly, it was a conscious decision to make it more cumbersome to apply lossy compression to a jpg (or git for...

Guidance for lossy 16bit compression

Adding @szabadka to the conversation, having added https://github.com/libjxl/libjxl/commit/da5d05e35a1d9f9564cb3af0d8389e7b9c1eb564 recently.