Max Korbel

Results 94 comments of Max Korbel

It's also worth considering which should be errors vs exceptions: https://stackoverflow.com/questions/17315945/error-vs-exception-in-dart

When creating this, we can also add new capabilities like adding the stall signals as part of the stage themselves instead of as a separate input into the Pipeline abstraction....

> Can we extend `Function` to maintain backwards compatibility or is that not reasonable/possible? Apparently, no: https://github.com/dart-lang/sdk/issues/33748

The upcoming `ConditionalGroup` is an easy and reasonable place to add comments as well.

Some things to consider: - Unary operations (in gates and on `LogicValue`s) need to probably throw an error when called on a 0-width signal

@Sanchit-kumar sorry for the late response on this, somehow I missed your comment! PR #412 fixes the issues here. You're right regarding the typo in the example test in this...

Related discussion: https://github.com/intel/rohd/discussions/335

Since `Logic`s have an underlying `Wire`, this might not be too hard to implement. Basically instead of assigning with a single srcConnection, there has to be a way to connect...

While we're at it, we should really make `d` and `clk` private in `FlipFlop`

> After you run `dart pub get` on the package with the git dependency, can you check your `.dart_tool/package_config.json` file for the `rohd` entry. The pub cache location it points...