Marek Kaput
Marek Kaput
I'm out of the loop. @tarrencev are you able to declare these macros in Dojo via the mechanism that already exist in Scarb?
> do we include these as keywords in the parser? 👍🏻 This should happen IMO
> `indexmap` has a problem with `no-std` in its `1.X.X` version. It is described [here](https://github.com/bluss/indexmap/issues/258). So we have to use code that is on version `2.0.0-pre`, it could be achieved...
Yeah, @spapinistarkware I think we will need following separate grammars implementations: 1. Compiler one we have 2. Tree sitter as @xJonathanLEI said 3. TextMate bundle which is present in VSCode...
> For the PR title and commit message, since I failed to find a consistent commit style across the recent Git history, I'm using Conventional Commits instead. Please let me...
What's more, this also applies to crate names.
> Yeah if we eventually want to put this on crates.io then crate names should also be made cairo/starknet-speicifc. That's actually already an issue, because I have to use these...
*[`adrs/005_mut.md` line 32 at r3](https://reviewable.io/reviews/starkware-libs/cairo2/433#-NCZNZgY59VWXgf8XxRK:-NCZa0uD0DnTCZ3FKSC3:b-f822a5) ([raw file](https://github.com/starkware-libs/cairo2/blob/a2e2c140a77c6472f8656368882c54aae9635aa9/adrs/005_mut.md#L32)):* Previously, ilyalesokhin-starkware wrote… how will this work with self? 1. `mut self` 2. `mut self, mut a, mut b` 2. `self, mut a,...
*[`adrs/005_mut.md` line 32 at r3](https://reviewable.io/reviews/starkware-libs/cairo2/433#-NCZNZgY59VWXgf8XxRK:-NCZaNV57xKtdGaPqIwU:bpvvj3a) ([raw file](https://github.com/starkware-libs/cairo2/blob/a2e2c140a77c6472f8656368882c54aae9635aa9/adrs/005_mut.md#L32)):* Previously, mkaput (Marek Kaput) wrote… 1. `mut self` 2. `mut self, mut a, mut b` 2. `self, mut a, mut b` All of...
*[`adrs/004_implicits.md` line 41 at r2](https://reviewable.io/reviews/starkware-libs/cairo2/431#-NCKAhUw3q9Gme1Ecgsh:-NCKAhUw3q9Gme1Ecgsi:undefined) ([raw file](https://github.com/starkware-libs/cairo2/blob/9f066e46557c618b86674bbd8e86280fda05cf8e/adrs/004_implicits.md#L41)):* > ```Markdown > func felt_le{RangeCheck}(a: felt, b: felt) -> bool; > ``` > This are similar to Cairo0. > ``` _Suggestion:_ ```Markdown This...