cairo icon indicating copy to clipboard operation
cairo copied to clipboard

Allow downstream macros

Open tarrencev opened this issue 2 years ago • 3 comments
trafficstars

Similar to how we allow downstream derives for now


This change is Reviewable

tarrencev avatar Jul 26 '23 20:07 tarrencev

I'm out of the loop. @tarrencev are you able to declare these macros in Dojo via the mechanism that already exist in Scarb?

mkaput avatar Jul 27 '23 12:07 mkaput

I'm out of the loop. @tarrencev are you able to declare these macros in Dojo via the mechanism that already exist in Scarb?

Hmm I wasn't aware of a mechanism in scarb, do you mind sharing more?

tarrencev avatar Jul 27 '23 12:07 tarrencev

I meant the CairoPluginRepository thingy that you use for the semantic plugin. Are you able to use InlineMacros via it or do you miss something on Scarb's side also here?

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Oh yes we are using that but the core inline macro plugin is registered earlier in the pipeline and emits a diagnostic for any macro it doesn't understand.

From what I can tell, it isn't possible to register our inline macro plugin before the core implementation?

tarrencev avatar Jul 31 '23 15:07 tarrencev