Marek Kaput

Results 122 comments of Marek Kaput
trafficstars

> The purpose of the new hint interface is to have stricter and clearer boundaries between hints and the VM itself, so that hints can only access the parts of...

What about enforcing a contract that the signer should have the same constructor as StarknetCurveSigner has?

> Why should `StarknetCurveSigner` dictate how constructors of other signers should look like? Isn't this de facto standard? > Signing is one responsibility, creating a signer is another. One can...

> If that's a standard, what's the point of custom signers? They are going to be different by definition. This is also a thing that I don't understand. @Arcticae is...

My intuition is to prefer absolute imports (because these are automagically managed by an IDE) except in `__init__.py`/grouping modules, where relative imports look nicer (and are written manually). But in...

Related issues: - https://github.com/software-mansion/protostar/issues/518 - https://github.com/software-mansion/protostar/issues/954

I thought about this a little and my conclusions are: 1. The store&load example is not good, because you can simply put the overriding store call inside `test_a` directly. 2....

> We discussed this case with @kasperski95 and decided to give the user just a hint about adding a proper entry to the `protostar.toml`. @mkaput what do you think? Looks...

Example approach for this taken by `mix test`: https://hexdocs.pm/mix/1.14.0-rc.1/Mix.Tasks.Test.html#module-file-system-watchers

hmm I was more thinking about adding an explicit list of profiled properties, maybe even with some screenshots