cairo icon indicating copy to clipboard operation
cairo copied to clipboard

fix(formatter): incorrect exit code on files with syntax errors

Open xJonathanLEI opened this issue 2 years ago • 1 comments

Fixes #1088.

For the PR title and commit message, since I failed to find a consistent commit style across the recent Git history, I'm using Conventional Commits instead. Please let me know if there's a desired style, thanks!


This change is Reviewable

xJonathanLEI avatar Nov 26 '22 06:11 xJonathanLEI

For the PR title and commit message, since I failed to find a consistent commit style across the recent Git history, I'm using Conventional Commits instead. Please let me know if there's a desired style, thanks!

I do not recall any conversations about message style so in general I'd simply assume using descriptive titles 😃 your title is perfectly fine!

mkaput avatar Nov 26 '22 11:11 mkaput

Thanks for the reviews! Please let me know if anything is pending from my side.

xJonathanLEI avatar Nov 28 '22 13:11 xJonathanLEI

Ah I wasn't aware of that being a requirement. Rebased now :)

xJonathanLEI avatar Nov 28 '22 14:11 xJonathanLEI

Wait that's auto-merged? lol

xJonathanLEI avatar Nov 28 '22 14:11 xJonathanLEI

Oops, I tihnk we broke main :S weird, Ill check why CI didnt stop it

spapinistarkware avatar Nov 28 '22 14:11 spapinistarkware

Yeah I thought the auto-merge were going through only if CI passes.

xJonathanLEI avatar Nov 28 '22 14:11 xJonathanLEI

Seems it's not a mandatory check (the cairo-fmt check), No worries then:)

spapinistarkware avatar Nov 28 '22 14:11 spapinistarkware