cairo
cairo copied to clipboard
fix(formatter): incorrect exit code on files with syntax errors
Fixes #1088.
For the PR title and commit message, since I failed to find a consistent commit style across the recent Git history, I'm using Conventional Commits instead. Please let me know if there's a desired style, thanks!
For the PR title and commit message, since I failed to find a consistent commit style across the recent Git history, I'm using Conventional Commits instead. Please let me know if there's a desired style, thanks!
I do not recall any conversations about message style so in general I'd simply assume using descriptive titles 😃 your title is perfectly fine!
Thanks for the reviews! Please let me know if anything is pending from my side.
Ah I wasn't aware of that being a requirement. Rebased now :)
Wait that's auto-merged? lol
Oops, I tihnk we broke main :S weird, Ill check why CI didnt stop it
Yeah I thought the auto-merge were going through only if CI passes.
Seems it's not a mandatory check (the cairo-fmt check), No worries then:)