Marek Kaput

Results 132 comments of Marek Kaput

Hmm, I would definitely not send NACK and just let the message timeout here. This is the existing behaviour. Mind that `PullConsumer` is modelled after `GenServer` and there, raising within...

> This feels awkward to me because our PullConsumer can start at any point in the message history, and when we start supporting parallel message processing, which version of the...

This is an use-case that I do not want to support in PullConsumer as it is meant to be a super simple API serving say 60-70% use-cases. See #8. Your...

> Is there a link to the file? I don't understand. Please elaborate.

https://github.com/starkware-libs/cairo/blob/037223273235aa6205a75df310a6c605ee9ea46e/crates/cairo-lang-language-server/src/ide/code_actions/mod.rs

https://github.com/astral-sh/ruff/tree/main/crates/ruff_server

For short strings/strings we might also want to show their numeric value (basically bring https://www.stark-utils.xyz/converter into LS)

@zmalatrax please use Reviewable for responding to comments :)

Hey! Here's the starting point: https://github.com/starkware-libs/cairo/blob/cdaceb909ccf0644b7e385669d2c48417ceb90d4/crates/cairo-lang-language-server/src/ide/code_actions/mod.rs#L34-L78 You can follow the implementation of unused variable intention as the hooking point. First, you need to assign an error code to this particular...

@the-first-elder any progress? how can we help?