Marek Kaput

Results 108 comments of Marek Kaput
trafficstars

The `CheatableBlockchainCommander` seems to fulfil exactly the same role as `Cheaters` which I pursue in #775. I think we just thought of different names

Yeah, that's right. `Cheaters` will be local to `protostar.starknet`.

> Ideally, the adapter should be moved to `cairo-lang` package, hence the state must be kept on the Protostar side. The trick is that we 99% will not get this...

> The problem I see with `Cheaters` is that they manage the state of the cheat, and the `Cheaters` are part of the adapter (`protostar.starknet`). > > Ideally, the adapter...

> ```python > blockchain.add_cheatcode(WarpCheatcode(blockchain, state)) > ``` > > ```python > class WarpCheatcode(Cheatcode): > def __init__(self, blockchain, state): > self._blockchain = blockchain, > self._state=state > > @property > def name(self)...

> Cheaters are on the wrong side of the boundary. They will prevent moving the adapter part to the `cairo-lang` library. The name is bad, but in general I don't...

We have to discuss this F2F soon.

1. I wouldn't introduce a change in conventions if we already settled on `src` for long time. 2. Hmm, but `lib` and `tests` are also conflicting with frontend repos.

Submitted #996, as for now, let's proceed merging that.