Michele Esposito

Results 16 issues of Michele Esposito

`babel-runtime` package is included in multiple `@metamask/controllers`' direct deps: It is unused but takes up bundle size.

team-extension-platform
product-backlog

## **Description** ## **Related issues** Fixes: #22594 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [...

This issue aims to provide a list of observations and possible proposals to simplify the `KeyringController` API, removing unnecessary, redundant, out-of-scope, and confusing methods. The `KeyringController` responsibilities should be the...

team-shared-libraries

After merging the TypeScript migration PR (https://github.com/MetaMask/eth-trezor-keyring/pull/161) we should now implement the [`Keyring` interface from utils package](https://github.com/MetaMask/utils/pull/74) as for other keyrings.

The Ledger keyring should extend the [Keyring type](https://github.com/MetaMask/utils/blob/main/src/keyring.ts#L47) as other keyrings.

team-wallet-framework

## **Description** The primary purpose for upgrading this package is to ensure that we are using a version which relies on `@metamask/base-controller` v4, which protects state from being mutated accidentally...

dependencies
team-shared-libraries

## **Description** The primary purpose for upgrading this package is to ensure that we are using a version that relies on `@metamask/base-controller` v4, which protects the state from being mutated...

dependencies
team-shared-libraries

## Explanation This PR adds the `KeyringController:withKeyring` action to `KeyringController`. ## References * Related to #4197 ## Changelog ### `@metamask/keyring-controller` - **ADDED**: Added `KeyringController:withKeyring` action - **DEPRECATED**: Deprecated `KeyringController:getKeyringForAccount` action...

## Explanation This PR adds the `PhishingDetector` class from `eth-phising-detector`, along with some utility functions into the `@metamask/phishing-controller` package, converting all to Typescript and Jest. ## References ## Changelog ###...

## Explanation ## References ## Changelog ### `@metamask/package-a` - ****: Your change here - ****: Your change here ### `@metamask/package-b` - ****: Your change here - ****: Your change here...