core icon indicating copy to clipboard operation
core copied to clipboard

[phishing-controller] Add `PhishingDetector` from `eth-phishing-detector`

Open mikesposito opened this issue 10 months ago • 4 comments

Explanation

This PR adds the PhishingDetector class from eth-phising-detector, along with some utility functions into the @metamask/phishing-controller package, converting all to Typescript and Jest.

References

Changelog

@metamask/phishing-detector

  • ADDED: Added PhishingDetector from eth-phising-detector
    • The class, utils and tests have been converted to typescript

Checklist

  • [x] I've updated the test suite for new or updated code as appropriate
  • [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

mikesposito avatar Apr 08 '24 12:04 mikesposito

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 21.3 kB ka-weihe

View full report↗︎

socket-security[bot] avatar Apr 08 '24 12:04 socket-security[bot]

Main files from eth-phishing-detector original package have been added in this commit 1775471f86163696226976dbbaf6c8dace6d0dfc for an easier diff

mikesposito avatar Apr 09 '24 10:04 mikesposito

@mikesposito Is the plan to eventually remove the relevant code from https://github.com/MetaMask/eth-phishing-detect/blob/main/src/detector.js and centralize everything here instead?

NicholasEllul avatar Apr 10 '24 18:04 NicholasEllul

@NicholasEllul exactly! the plan is to leave the eth-phishing-detect package for the configuration only. We'll remove the PhishingDetector implementation from that package once we have it here

mikesposito avatar Apr 11 '24 08:04 mikesposito