metamask-extension
metamask-extension copied to clipboard
`PreferencesController` reacts to `KeyringController` state changes
Description
Related issues
Fixes: #22594
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.46%. Comparing base (
2e91b54
) to head (a432ba3
).
:exclamation: Current head a432ba3 differs from pull request most recent head a93932a. Consider uploading reports for the commit a93932a to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #22949 +/- ##
===========================================
- Coverage 68.49% 68.46% -0.03%
===========================================
Files 1092 1089 -3
Lines 43170 43038 -132
Branches 11512 11461 -51
===========================================
- Hits 29567 29463 -104
+ Misses 13603 13575 -28
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [a432ba3]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1087 ± 77 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 120 | 338 | 195 | 59 | 28 |
domContentLoaded | 9 | 91 | 38 | 29 | 14 | ||
load | 902 | 1624 | 1087 | 161 | 77 | ||
domInteractive | 9 | 91 | 38 | 29 | 14 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 246 Bytes (0.01%)
- ui: 0 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Builds ready [a93932a]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1690 ± 65 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 79 | 254 | 167 | 48 | 23 |
domContentLoaded | 9 | 84 | 32 | 23 | 11 | ||
load | 1492 | 1975 | 1690 | 135 | 65 | ||
domInteractive | 9 | 84 | 32 | 23 | 11 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 246 Bytes (0.01%)
- ui: 0 Bytes (0.00%)
- common: 0 Bytes (0.00%)