metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore(deps): Bump permission-log-controller to ^2.0.1

Open mikesposito opened this issue 9 months ago • 5 comments

Description

The primary purpose for upgrading this package is to ensure that we are using a version that relies on @metamask/base-controller v4, which protects the state from being mutated accidentally and includes more type safety for messengers, among other improvements.

See changelog: https://github.com/MetaMask/core/blob/%40metamask/permission-log-controller%402.0.1/packages/permission-log-controller/CHANGELOG.md

Open in GitHub Codespaces

Related issues

Progresses https://github.com/MetaMask/metamask-extension/issues/24140

Manual testing steps

There should be no functional changes in this PR

Screenshots/Recordings

None

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

mikesposito avatar May 08 '24 12:05 mikesposito

@metamaskbot update-policies

mikesposito avatar May 08 '24 12:05 mikesposito

Policies updated

metamaskbot avatar May 08 '24 12:05 metamaskbot

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 124 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar May 08 '24 12:05 socket-security[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.48%. Comparing base (d27a233) to head (1948bbc). Report is 57 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24432      +/-   ##
===========================================
+ Coverage    67.37%   67.48%   +0.11%     
===========================================
  Files         1278     1288      +10     
  Lines        49881    50153     +272     
  Branches     12944    13023      +79     
===========================================
+ Hits         33605    33842     +237     
- Misses       16276    16311      +35     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 22:05 codecov[bot]

Builds ready [753a8e4]
Page Load Metrics (1806 ± 694 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701871103517
domContentLoaded96419147
load54360618061445694
domInteractive96419147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.4 KiB (0.38%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 08 '24 23:05 metamaskbot

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 14 '24 10:05 github-actions[bot]

Builds ready [1948bbc]
Page Load Metrics (608 ± 524 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69157912613
domContentLoaded98018178
load5631696081092524
domInteractive98017178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.4 KiB (0.38%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 14 '24 12:05 metamaskbot