metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

chore(deps): Bump notification-controller to ^5.0.1

Open mikesposito opened this issue 9 months ago • 5 comments

Description

The primary purpose for upgrading this package is to ensure that we are using a version which relies on @metamask/base-controller v4, which protects state from being mutated accidentally and includes more type safety for messengers, among other improvements.

See changelog: https://github.com/MetaMask/core/blob/%40metamask/notification-controller%405.0.1/packages/notification-controller/CHANGELOG.md

Open in GitHub Codespaces

Related issues

Progresses https://github.com/MetaMask/metamask-extension/issues/24140

Manual testing steps

There should be no functional changes in this PR

Screenshots/Recordings

None

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

mikesposito avatar May 08 '24 10:05 mikesposito

@metamaskbot update-policies

mikesposito avatar May 08 '24 11:05 mikesposito

Policies updated

metamaskbot avatar May 08 '24 11:05 metamaskbot

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 0 B

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar May 08 '24 11:05 socket-security[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.65%. Comparing base (2cd5813) to head (f75a4af). Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24430   +/-   ##
========================================
  Coverage    69.65%   69.65%           
========================================
  Files         1347     1347           
  Lines        47808    47808           
  Branches     13187    13187           
========================================
  Hits         33300    33300           
  Misses       14508    14508

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 22:05 codecov[bot]

Builds ready [2de8b77]
Page Load Metrics (540 ± 459 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6412183167
domContentLoaded9241252
load532560540956459
domInteractive9241252
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -26.45 KiB (-0.81%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 09 '24 10:05 metamaskbot

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 13 '24 08:05 github-actions[bot]

Builds ready [feb1f32]
Page Load Metrics (962 ± 588 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint591681073215
domContentLoaded96323178
load4834019621225588
domInteractive96323178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -26.45 KiB (-0.78%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 21 '24 12:05 metamaskbot

Builds ready [9c49dd4]
Page Load Metrics (1046 ± 582 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint66158953015
domContentLoaded95515105
load54294810461211582
domInteractive95515105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -26.45 KiB (-0.77%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 22 '24 11:05 metamaskbot

@metamaskbot update-policies

mikesposito avatar May 29 '24 11:05 mikesposito

Policies updated

metamaskbot avatar May 29 '24 11:05 metamaskbot

Builds ready [6843c3f]
Page Load Metrics (974 ± 585 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671781083215
domContentLoaded96314115
load5528069741219585
domInteractive96314115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -26.45 KiB (-0.75%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 29 '24 11:05 metamaskbot

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Jun 04 '24 09:06 socket-security[bot]

Builds ready [d880714]
Page Load Metrics (318 ± 307 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67213983115
domContentLoaded8171121
load432302318640307
domInteractive8171121
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -26.45 KiB (-0.83%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jun 05 '24 09:06 metamaskbot

@metamaskbot update-policies

mcmire avatar Jun 06 '24 20:06 mcmire

Policies updated

metamaskbot avatar Jun 06 '24 20:06 metamaskbot

@metamaskbot update-policies

Gudahtt avatar Jun 13 '24 15:06 Gudahtt

Policies updated

metamaskbot avatar Jun 13 '24 15:06 metamaskbot

@metamaskbot update-policies

mcmire avatar Jun 18 '24 19:06 mcmire

Policies updated

metamaskbot avatar Jun 18 '24 20:06 metamaskbot

@metamaskbot update-policies

mcmire avatar Jun 25 '24 00:06 mcmire

Policies updated

metamaskbot avatar Jun 25 '24 00:06 metamaskbot

Builds ready [46cb79a]
Page Load Metrics (41 ± 2 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57887195
domContentLoaded813911
load37564152
domInteractive813911
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -39.13 KiB (-1.13%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jun 25 '24 00:06 metamaskbot

Builds ready [f75a4af]
Page Load Metrics (49 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6210082105
domContentLoaded9191121
load41654963
domInteractive9191121
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -39.13 KiB (-1.13%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Jun 25 '24 21:06 metamaskbot