methylDragon
methylDragon
I just had an idea, I will create an `rcl_time_valid()` method in `rcl` to encode the notion of non-zero time validity, and use it alongside `rcl_clock_valid()` here. Implemented here: https://github.com/ros2/rcl/pull/1018...
Hey @fujitatomoya , with the merge of https://github.com/ros2/rcl/pull/1018 , the validity check is now codified in `rcl`! I think we can merge this PR once CI goes green, what do...
@ros-pull-request-builder retest this please
This PR has been updated to use this PR instead: - https://github.com/ros2/rcl/pull/1021 instead **This PR will fail until that PR is merged** It doesn't make sense for a non-zero time...
@ros-pull-request-builder retest this please
> @methylDragon thanks for iterating with patience, so this has been update and ready to review, right? Hey @fujitatomoya , this is ready, yep! Though it'll take awhile for `rcl`...
* Linux [](http://ci.ros2.org/job/ci_linux/17820/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/12387/) * Windows [](http://ci.ros2.org/job/ci_windows/18485/)
@Mergifyio backport humble
Held for sync: https://discourse.ros.org/t/preparing-for-humble-sync-and-patch-release-2022-11-21/28234
Holding for sync: https://discourse.ros.org/t/preparing-for-humble-sync-and-patch-release-2022-11-21/28234