methylDragon
methylDragon
> Does `/internal_node` still get renamed if it's node options get `use_global_arguments` set to false? I suspect it's picking up the name remap rule that was intended for the component...
Only thing I'm unsure of if if I should leave the NodeT constructor for `NodeHandle` explicit. If it's not explicit we can rely on implicit conversion to allow passing in...
Will build [#11111](https://ci.ros2.org/job/ci_launcher/11111) be the one??? * Linux [](http://ci.ros2.org/job/ci_linux/17625/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/12172/) * Windows [](http://ci.ros2.org/job/ci_windows/18199/)
> I like the overall idea. However I have a couple of questions from looking at your examples. > > It seems like there are multiple methods to retrieve each...
> I'd also like to talk about the name of the new class `NodeHandle`. I think we should pick something else because really it's not a "handle" (we already have...
@ros-pull-request-builder retest this please
> > I'd also like to talk about the name of the new class NodeHandle. I think we should pick something else because really it's not a "handle" (we already...
I've updated the tests and moved everything to node_interfaces! RPr is green!
> > Could I double-check that this +1 is over NodeInterfaceHandle (so +1 to NodeInterfaces even though NodeInterfaceHandle exists?) The multiple inheritance templated example you gave above used NodeInterfaceHandle grimacing....
Class has been renamed! (The only thing that's iffy to me is it makes the include path `rclcpp/node_interfaces/node_interfaces.hpp`, which could potentially be misleading..) --- That, and, I was wondering if...