methylDragon
methylDragon
There are some further discussions about the C++ classes on the parent PR: - https://github.com/ros2/rclcpp/pull/2176#issuecomment-1552190126 - https://github.com/ros2/rclcpp/pull/2176#issuecomment-1552220254
Yeah, this makes sense! Though since this is a more specific case, I would recommend implementing it as a new [FeaturesInterface](https://github.com/moveit/moveit2/blob/main/moveit_ros/trajectory_cache/include/moveit/trajectory_cache/features/features_interface.hpp) implementation and pass the new feature (alongside the other...
> [@sea-bass](https://github.com/sea-bass) In my opinion having an arm on wheeled base is quite common So we should add it as a boolean. Implementing it as a new featureInterface will not...
> > I'm a little bit more neutral on whether we should also filter out the joints that get added to the cache. The only thing that would do is...
Quick question: clang-format/tidy is erroneously editing the template parameters. How do I get around it? Related bug: https://github.com/llvm/llvm-project/issues/46097 Is it acceptable to throw in NOLINT directives?
I am opening this PR because it is now complete enough to warrant a review. It is only missing a refactor of the integration test. I added unit/sanity tests (though...
CI is failing due to the `jump_threshold` arg being called on `computeCartesianPlan`. But the cache needs to consider it due to the field's presence in the [`GetCartesianPath`](https://github.com/moveit/moveit_msgs/blob/ros2/srv/GetCartesianPath.srv#L57-L58) service... How do...
Are we good to merge? (: @sjahr Quoting from before: > CI is failing due to the `jump_threshold` arg being called on `computeCartesianPlan`. But the cache needs to consider it...
Small poke @sjahr (: