Chris Stackhouse
Chris Stackhouse
> "name": { Recommend replacing name, location, and tags with a reference to the TrackedResource definition from v5 common types. --- Refers to: specification/automation/resource-manager/Microsoft.Automation/preview/2023-05-15-preview/package.json:615 in a571cd1. [](commit_id = a571cd16481772faf625e99de4a8ded3363151da, deletion_comment...
> "x-ms-pageable": { FYI, this extension doesn't do anything for POST actions. IOW, paging support is not generated in the SDK. It's not harmful to have it here, but it...
> "x-ms-pageable": { Has no effect for POST actions. Comment applies to other POST actions in this file. --- In reply to: [1619367409](https://github.com/Azure/azure-rest-api-specs/pull/24384#issuecomment-1619367409) [](http://example.com/codeflow?ancestors=1619367409) --- Refers to: specification/security/resource-manager/Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json:384 in fa2d657....
> "description": "Id of the GitHub app installation.", Would be nice to mention the format (e.g. Uri, Guid, ) in the description. --- In reply to: [1619367509](https://github.com/Azure/azure-rest-api-specs/pull/24384#issuecomment-1619367509) [](http://example.com/codeflow?ancestors=1619367509) --- Refers...
@ivadim - Signed off for ARM with comments: please take a look.
> "ghazdoState": { Recommend only using very common acronyms/abbreviations (e.g. ip, pdf). Maybe githubAdvancedSecurityState...? --- In reply to: [1622740911](https://github.com/Azure/azure-rest-api-specs/pull/24384#issuecomment-1622740911) [](http://example.com/codeflow?ancestors=1622740911) --- Refers to: specification/security/resource-manager/Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json:3146 in f6d35a2. [](commit_id = f6d35a28777bec8bd0feff91a1e4d60d3ba594e1, deletion_comment...
@ivadim - Left a comment, please take a look.
@maciejtreder - Your PR needs to pass checks and address the CI-BreakingChange-Python-Track2 label before merge. Add the MergeRequested label back after addressing those items. If you get stuck, you can...
> "type": "boolean", Please consider moving to string enum for these kinds of properties. ARM review prefers enum over booleans for many reasons. Booleans are convenient for API developers, but...
> > > ``` > > > "type": "boolean", > > > ``` > > > > > > Please consider moving to string enum for these kinds of properties....