Chris Stackhouse
Chris Stackhouse
@cassasin - Changing response codes requires breaking change review (see comment for instructions: https://github.com/Azure/azure-rest-api-specs/pull/24334#issuecomment-1594510134).
> "description": "No Content" Deployment was successfully deleted or doesn't exist. --- Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json:1199 in 93481ca. [](commit_id = 93481caba2834e22b86fb93995e8a36e68fa13aa, deletion_comment = False)
> "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" Consider moving to v5 common type. Comment applies throughout. #Closed --- Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2024-01-01-preview/workspaceRP.json:808 in 93481ca. [](commit_id = 93481caba2834e22b86fb93995e8a36e68fa13aa, deletion_comment = False)
> This new apiversion is moved from [RPSaaSMaster of private swagger repository](https://github.com/Azure/azure-rest-api-specs-pr/tree/RPSaaSMaster/specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2023-11-01-preview). All the changes have been reviewed and approved before. Please help merge it. Thanks Couple of things: 1....
@hdmimsft - This looks like it's implementing an internal contract for another RP, rather than providing end-user resource types, so I've reviewed it accordingly. Assuming I've guessed correctly, can you...
> @mentat9. Chris, how do we progress with this PR. We sent you design docs in email. @hdmimsft - Per this comment, your PR goes back into the reviewer queue...
@gachauhan - Please fill out the intake form at the top. This is required for all swagger PRs to ensure correct routing and automation handling.
@gachauhan - Signing off for ARM with comments.
> > > ``` > > > "name": "continuationToken", > > > ``` > > > > > > [ARMBlockingComment] What is the query parameter for? You still have nextLink...
@kushalmehrotra713 - Please address open comments from @visingla-ms and @dhruvesh.