Chris Stackhouse
Chris Stackhouse
@petrkotas - Please refresh to fix merge failures and re-apply MergeRequested label.
Merge without branch refresh should be OK per comment in API Spec Review team here: https://teams.microsoft.com/l/message/19:[email protected]/1715629299216?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1715624451175&teamName=Azure%20SDK&channelName=API%20Spec%20Review&createdTime=1715629299216. However, merge is currently blocked by @TimLovellSmith pending review comments. Tim, please approve or...
> "$ref": "#/definitions/CloudError" Non-blocking, but recommended that teams move to ErrorResponse from v4 common types for new APIs. --- Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2023-01-01/storagecache.json:1838 in 30d4c64. [](commit_id = 30d4c64c2167a84401850e8f6f180f0aa0092b10, deletion_comment = False)
@rebecca337 - I've signed off for ARM with comments.
> "name": { Don't duplicate top-level property names within the property bag. Consider runtimeEnvironmentName or similar. --- In reply to: [1626351619](https://github.com/Azure/azure-rest-api-specs/pull/23988#issuecomment-1626351619) [](http://example.com/codeflow?ancestors=1626351619) --- In reply to: [1626351619](https://github.com/Azure/azure-rest-api-specs/pull/23988#issuecomment-1626351619) [](http://example.com/codeflow?ancestors=1626351619) --- Refers...
> "runtimeEnvironment": { Why is this a string in the create request, but an object in the collection response? Can you make them consistent? The ARM RPC actually requires that...
> "$ref": "../../common/v1/definitions.json#/parameters/ResourceGroupNameParameter" Consider moving to v5 common types for new APIs. Comment applies throughout the updates in this PR. --- In reply to: [1626382833](https://github.com/Azure/azure-rest-api-specs/pull/23988#issuecomment-1626382833) [](http://example.com/codeflow?ancestors=1626382833) --- Refers to: specification/automation/resource-manager/Microsoft.Automation/preview/2023-05-15-preview/package.json:56...
> "name": { Recommend replacing name, location, and tags with a reference to the TrackedResource definition from v5 common types. --- Refers to: specification/automation/resource-manager/Microsoft.Automation/preview/2023-05-15-preview/package.json:509 in a571cd1. [](commit_id = a571cd16481772faf625e99de4a8ded3363151da, deletion_comment...
> "enum": [ Canceled (spelled like that) is a a required value. --- Refers to: specification/automation/resource-manager/Microsoft.Automation/preview/2023-05-15-preview/package.json:549 in a571cd1. [](commit_id = a571cd16481772faf625e99de4a8ded3363151da, deletion_comment = False)
> "creationTime": { This and lastModifiedTime belong in the systemData top-level object (see TrackedResource definition in v5 common types). --- Refers to: specification/automation/resource-manager/Microsoft.Automation/preview/2023-05-15-preview/package.json:580 in a571cd1. [](commit_id = a571cd16481772faf625e99de4a8ded3363151da, deletion_comment =...