Chris Stackhouse

@yanfa317 - Please use the instructions in this comment to request ARM revisit of your PR: https://github.com/Azure/azure-rest-api-specs/pull/21970#issuecomment-1368044696.

> "/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectionClusters": { Use camelcase "subscription". Comment applies to other new APIs as well. --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2023-01-01/service.json:4548 in 5504713. [](commit_id = 55047137a9865a47187a92b0ad3f3f56a6268a66, deletion_comment = False)

> "/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectionClusters": { Use a better name like vaultName. resourceName is too generic. Comment applies to other new APIs as well. --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2023-01-01/service.json:4548 in 5504713. [](commit_id = 55047137a9865a47187a92b0ad3f3f56a6268a66,...

> "$ref": "#/parameters/ApiVersion" Should get this by $ref'ing ApiVersionParameter definition from v4 common types. Likewise ResourceGroupName (ResourceGroupNameParameter), and SubscriptionId (SubscriptionIdParameter). This comment applies to the other new APIs as well....

> "$ref": "#/definitions/ServiceError" Should use the ErrorResponse definition from v4 common types. Comment applies elsewhere in APIs being added as well. --- In reply to: [1374373916](https://github.com/Azure/azure-rest-api-specs/pull/21951#issuecomment-1374373916) [](http://example.com/codeflow?ancestors=1374373916) --- Refers to:...

> "/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectionClusters/{replicationProtectionClusterName}/create": { This should be modeled as PUT, not a create POST action. I think this will just fail in ARM with 404 anyway. --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2023-01-01/service.json:4818 in...

> "responses": { Need 200 for final response --- In reply to: [1374373961](https://github.com/Azure/azure-rest-api-specs/pull/21951#issuecomment-1374373961) [](http://example.com/codeflow?ancestors=1374373961) --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2023-01-01/service.json:4940 in 5504713. [](commit_id = 55047137a9865a47187a92b0ad3f3f56a6268a66, deletion_comment = False)

> "responses": { Need 200 for final response --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2023-01-01/service.json:5017 in 5504713. [](commit_id = 55047137a9865a47187a92b0ad3f3f56a6268a66, deletion_comment = False)

@pradheepm - I started ARM review, but was unable to finish by the end of my rotation. Next oncall is @TimLovellSmith who will continue next week.

@ashutoshsuman99 - If/when you need ARM review, please set your PR to Open.