Chris Stackhouse
Chris Stackhouse
@xiaoxuqi-ms - I've signed off for ARM with comments. Please take a look.
@singhabh27 - Please read and fill out the intake form carefully and completely.
> "diskType": { This is used in many places: consider moving it to a common definition below and $ref-ing it where it's used. --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:12296 in e245e8d. [](commit_id...
> "targetDiskAccountType": { Does this also take a fixed number of values? If so, it should be modeled as a string enum as well. --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:12584 in e245e8d....
> "diskType": { Consider using a $ref to a common definition. --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:12450 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
> "diskType": { Same here --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:13742 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
> "diskType": { Same --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:13836 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
> "diskType": { Same --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:15477 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
> "diskType": { Same --- Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:15520 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)