azure-rest-api-specs
azure-rest-api-specs copied to clipboard
[Hub Generated] Review request for Microsoft.Security to add version preview/2023-09-01-preview
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [x] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. Guestimate - July 2023
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. Guestimate - September 2023
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [x] I have reviewed the documentation for the workflow.
- [x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @ivadim Thanks for your PR. I am workflow bot for review process. Here are some small tips.
Swagger Validation Report
️️✔️
BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 7 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-composite-v3 | package-composite-v3(6339728) | package-composite-v3(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
:warning: PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listavailableazuredevopsorgs' in:'AzureDevOpsOrgs_ListAvailable'. Consider updating the operationId Location: Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json#L19 |
|
:warning: PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listavailablegithubowners' in:'GitHubOwners_ListAvailable'. Consider updating the operationId Location: Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json#L1078 |
|
:warning: PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listavailablegitlabgroups' in:'GitLabGroups_ListAvailable'. Consider updating the operationId Location: Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json#L1321 |
|
:warning: PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listsubgroups' in:'GitLabSubgroups_List'. Consider updating the operationId Location: Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json#L1462 |
|
:warning: AllProxyResourcesShouldHaveDelete | The resource AzureDevOpsOrg does not have a corresponding delete operation. Location: Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json#L1735 |
RPC-Delete-V1-05 |
:warning: AllProxyResourcesShouldHaveDelete | The resource AzureDevOpsProject does not have a corresponding delete operation. Location: Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json#L1814 |
RPC-Delete-V1-05 |
:warning: AllProxyResourcesShouldHaveDelete | The resource AzureDevOpsRepository does not have a corresponding delete operation. Location: Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json#L1902 |
RPC-Delete-V1-05 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
:warning: MULTIPLE_API_VERSION | The default tag contains multiple API versions swaggers. readme: specification/security/resource-manager/readme.md tag: specification/security/resource-manager/readme.md#tag-package-composite-v3 |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️
ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌
SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌
azure-sdk-for-go - sdk/resourcemanager/security/armsecurity - Approved - 0.12.0+ Enum `ScopeName` has been removed + Function `*ClientFactory.NewHealthReportClient` has been removed + Function `*HealthReportClient.Get` has been removed + Function `NewHealthReportClient` has been removed + Type of `HealthDataClassification.Scope` has been changed from `*ScopeName` to `*string`
️️✔️
azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 64ffad1a3042017e07f8a47df17d6acaa2c1e609. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️
Azure.ResourceManager.SecurityCenter [View full logs] [Release SDK Changes]info [Changelog]
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 64ffad1a3042017e07f8a47df17d6acaa2c1e609. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️
sdk/resourcemanager/security/armsecurity [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - New enum type `RuleCategory` with values `RuleCategoryArtifacts`, `RuleCategoryCode`, `RuleCategoryContainers`, `RuleCategoryDependencies`, `RuleCategoryIaC`, `RuleCategorySecrets` info [Changelog] - New enum type `ServerVulnerabilityAssessmentsAzureSettingSelectedProvider` with values `ServerVulnerabilityAssessmentsAzureSettingSelectedProviderMdeTvm` info [Changelog] - New enum type `ServerVulnerabilityAssessmentsSettingKind` with values `ServerVulnerabilityAssessmentsSettingKindAzureServersSetting` info [Changelog] - New enum type `ServerVulnerabilityAssessmentsSettingKindName` with values `ServerVulnerabilityAssessmentsSettingKindNameAzureServersSetting` info [Changelog] - New enum type `SettingNameAutoGenerated` with values `SettingNameAutoGeneratedCurrent` info [Changelog] - New function `NewAzureDevOpsOrgsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureDevOpsOrgsClient, error)` info [Changelog] - New function `*AzureDevOpsOrgsClient.BeginCreateOrUpdate(context.Context, string, string, string, AzureDevOpsOrg, *AzureDevOpsOrgsClientBeginCreateOrUpdateOptions) (*runtime.Poller[AzureDevOpsOrgsClientCreateOrUpdateResponse], error)` info [Changelog] - New function `*AzureDevOpsOrgsClient.Get(context.Context, string, string, string, *AzureDevOpsOrgsClientGetOptions) (AzureDevOpsOrgsClientGetResponse, error)` info [Changelog] - New function `*AzureDevOpsOrgsClient.ListAvailable(context.Context, string, string, *AzureDevOpsOrgsClientListAvailableOptions) (AzureDevOpsOrgsClientListAvailableResponse, error)` info [Changelog] - New function `*AzureDevOpsOrgsClient.NewListPager(string, string, *AzureDevOpsOrgsClientListOptions) *runtime.Pager[AzureDevOpsOrgsClientListResponse]` info [Changelog] - New function `*AzureDevOpsOrgsClient.BeginUpdate(context.Context, string, string, string, AzureDevOpsOrg, *AzureDevOpsOrgsClientBeginUpdateOptions) (*runtime.Poller[AzureDevOpsOrgsClientUpdateResponse], error)` info [Changelog] - New function `NewAzureDevOpsProjectsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureDevOpsProjectsClient, error)` info [Changelog] - New function `*AzureDevOpsProjectsClient.BeginCreateOrUpdate(context.Context, string, string, string, string, AzureDevOpsProject, *AzureDevOpsProjectsClientBeginCreateOrUpdateOptions) (*runtime.Poller[AzureDevOpsProjectsClientCreateOrUpdateResponse], error)` info [Changelog] - New function `*AzureDevOpsProjectsClient.Get(context.Context, string, string, string, string, *AzureDevOpsProjectsClientGetOptions) (AzureDevOpsProjectsClientGetResponse, error)` info [Changelog] - New function `*AzureDevOpsProjectsClient.NewListPager(string, string, string, *AzureDevOpsProjectsClientListOptions) *runtime.Pager[AzureDevOpsProjectsClientListResponse]` info [Changelog] - New function `*AzureDevOpsProjectsClient.BeginUpdate(context.Context, string, string, string, string, AzureDevOpsProject, *AzureDevOpsProjectsClientBeginUpdateOptions) (*runtime.Poller[AzureDevOpsProjectsClientUpdateResponse], error)` info [Changelog] - New function `NewAzureDevOpsReposClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureDevOpsReposClient, error)` info [Changelog] - New function `*AzureDevOpsReposClient.BeginCreateOrUpdate(context.Context, string, string, string, string, string, AzureDevOpsRepository, *AzureDevOpsReposClientBeginCreateOrUpdateOptions) (*runtime.Poller[AzureDevOpsReposClientCreateOrUpdateResponse], error)` info [Changelog] - New function `*AzureDevOpsReposClient.Get(context.Context, string, string, string, string, string, *AzureDevOpsReposClientGetOptions) (AzureDevOpsReposClientGetResponse, error)` info [Changelog] - New function `*AzureDevOpsReposClient.NewListPager(string, string, string, string, *AzureDevOpsReposClientListOptions) *runtime.Pager[AzureDevOpsReposClientListResponse]` info [Changelog] - New function `*AzureDevOpsReposClient.BeginUpdate(context.Context, string, string, string, string, string, AzureDevOpsRepository, *AzureDevOpsReposClientBeginUpdateOptions) (*runtime.Poller[AzureDevOpsReposClientUpdateResponse], error)` info [Changelog] - New function `*AzureServersSetting.GetServerVulnerabilityAssessmentsSetting() *ServerVulnerabilityAssessmentsSetting` info [Changelog] - New function `*ClientFactory.NewAzureDevOpsOrgsClient() *AzureDevOpsOrgsClient` info [Changelog] - New function `*ClientFactory.NewAzureDevOpsProjectsClient() *AzureDevOpsProjectsClient` info [Changelog] - New function `*ClientFactory.NewAzureDevOpsReposClient() *AzureDevOpsReposClient` info [Changelog] - New function `*ClientFactory.NewDefenderForStorageClient() *DefenderForStorageClient` info [Changelog] - New function `*ClientFactory.NewDevOpsConfigurationsClient() *DevOpsConfigurationsClient` info [Changelog] - New function `*ClientFactory.NewDevOpsOperationResultsClient() *DevOpsOperationResultsClient` info [Changelog] - New function `*ClientFactory.NewGitHubOwnersClient() *GitHubOwnersClient` info [Changelog] - New function `*ClientFactory.NewGitHubReposClient() *GitHubReposClient` info [Changelog] - New function `*ClientFactory.NewGitLabGroupsClient() *GitLabGroupsClient` info [Changelog] - New function `*ClientFactory.NewGitLabProjectsClient() *GitLabProjectsClient` info [Changelog] - New function `*ClientFactory.NewGitLabSubgroupsClient() *GitLabSubgroupsClient` info [Changelog] - New function `*ClientFactory.NewServerVulnerabilityAssessmentsSettingsClient() *ServerVulnerabilityAssessmentsSettingsClient` info [Changelog] - New function `NewDefenderForStorageClient(azcore.TokenCredential, *arm.ClientOptions) (*DefenderForStorageClient, error)` info [Changelog] - New function `*DefenderForStorageClient.Create(context.Context, string, SettingNameAutoGenerated, DefenderForStorageSetting, *DefenderForStorageClientCreateOptions) (DefenderForStorageClientCreateResponse, error)` info [Changelog] - New function `*DefenderForStorageClient.Get(context.Context, string, SettingNameAutoGenerated, *DefenderForStorageClientGetOptions) (DefenderForStorageClientGetResponse, error)` info [Changelog] - New function `NewDevOpsConfigurationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DevOpsConfigurationsClient, error)` info [Changelog] - New function `*DevOpsConfigurationsClient.BeginCreateOrUpdate(context.Context, string, string, DevOpsConfiguration, *DevOpsConfigurationsClientBeginCreateOrUpdateOptions) (*runtime.Poller[DevOpsConfigurationsClientCreateOrUpdateResponse], error)` info [Changelog] - New function `*DevOpsConfigurationsClient.BeginDelete(context.Context, string, string, *DevOpsConfigurationsClientBeginDeleteOptions) (*runtime.Poller[DevOpsConfigurationsClientDeleteResponse], error)` info [Changelog] - New function `*DevOpsConfigurationsClient.Get(context.Context, string, string, *DevOpsConfigurationsClientGetOptions) (DevOpsConfigurationsClientGetResponse, error)` info [Changelog] - New function `*DevOpsConfigurationsClient.NewListPager(string, string, *DevOpsConfigurationsClientListOptions) *runtime.Pager[DevOpsConfigurationsClientListResponse]` info [Changelog] - New function `*DevOpsConfigurationsClient.BeginUpdate(context.Context, string, string, DevOpsConfiguration, *DevOpsConfigurationsClientBeginUpdateOptions) (*runtime.Poller[DevOpsConfigurationsClientUpdateResponse], error)` info [Changelog] - New function `NewDevOpsOperationResultsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DevOpsOperationResultsClient, error)` info [Changelog] - New function `*DevOpsOperationResultsClient.Get(context.Context, string, string, string, *DevOpsOperationResultsClientGetOptions) (DevOpsOperationResultsClientGetResponse, error)` info [Changelog] - New function `NewGitHubOwnersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*GitHubOwnersClient, error)` info [Changelog] - New function `*GitHubOwnersClient.Get(context.Context, string, string, string, *GitHubOwnersClientGetOptions) (GitHubOwnersClientGetResponse, error)` info [Changelog] - New function `*GitHubOwnersClient.ListAvailable(context.Context, string, string, *GitHubOwnersClientListAvailableOptions) (GitHubOwnersClientListAvailableResponse, error)` info [Changelog] - New function `*GitHubOwnersClient.NewListPager(string, string, *GitHubOwnersClientListOptions) *runtime.Pager[GitHubOwnersClientListResponse]` info [Changelog] - New function `NewGitHubReposClient(string, azcore.TokenCredential, *arm.ClientOptions) (*GitHubReposClient, error)` info [Changelog] - New function `*GitHubReposClient.Get(context.Context, string, string, string, string, *GitHubReposClientGetOptions) (GitHubReposClientGetResponse, error)` info [Changelog] - New function `*GitHubReposClient.NewListPager(string, string, string, *GitHubReposClientListOptions) *runtime.Pager[GitHubReposClientListResponse]` info [Changelog] - New function `NewGitLabGroupsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*GitLabGroupsClient, error)` info [Changelog] - New function `*GitLabGroupsClient.Get(context.Context, string, string, string, *GitLabGroupsClientGetOptions) (GitLabGroupsClientGetResponse, error)` info [Changelog] - New function `*GitLabGroupsClient.ListAvailable(context.Context, string, string, *GitLabGroupsClientListAvailableOptions) (GitLabGroupsClientListAvailableResponse, error)` info [Changelog] - New function `*GitLabGroupsClient.NewListPager(string, string, *GitLabGroupsClientListOptions) *runtime.Pager[GitLabGroupsClientListResponse]` info [Changelog] - New function `NewGitLabProjectsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*GitLabProjectsClient, error)` info [Changelog] - New function `*GitLabProjectsClient.Get(context.Context, string, string, string, string, *GitLabProjectsClientGetOptions) (GitLabProjectsClientGetResponse, error)` info [Changelog] - New function `*GitLabProjectsClient.NewListPager(string, string, string, *GitLabProjectsClientListOptions) *runtime.Pager[GitLabProjectsClientListResponse]` info [Changelog] - New function `NewGitLabSubgroupsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*GitLabSubgroupsClient, error)` info [Changelog] - New function `*GitLabSubgroupsClient.List(context.Context, string, string, string, *GitLabSubgroupsClientListOptions) (GitLabSubgroupsClientListResponse, error)` info [Changelog] - New function `*HealthReportsClient.Get(context.Context, string, string, *HealthReportsClientGetOptions) (HealthReportsClientGetResponse, error)` info [Changelog] - New function `*ServerVulnerabilityAssessmentsSetting.GetServerVulnerabilityAssessmentsSetting() *ServerVulnerabilityAssessmentsSetting` info [Changelog] - New function `NewServerVulnerabilityAssessmentsSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ServerVulnerabilityAssessmentsSettingsClient, error)` info [Changelog] - New function `*ServerVulnerabilityAssessmentsSettingsClient.CreateOrUpdate(context.Context, ServerVulnerabilityAssessmentsSettingKindName, ServerVulnerabilityAssessmentsSettingClassification, *ServerVulnerabilityAssessmentsSettingsClientCreateOrUpdateOptions) (ServerVulnerabilityAssessmentsSettingsClientCreateOrUpdateResponse, error)` info [Changelog] - New function `*ServerVulnerabilityAssessmentsSettingsClient.Delete(context.Context, ServerVulnerabilityAssessmentsSettingKindName, *ServerVulnerabilityAssessmentsSettingsClientDeleteOptions) (ServerVulnerabilityAssessmentsSettingsClientDeleteResponse, error)` info [Changelog] - New function `*ServerVulnerabilityAssessmentsSettingsClient.Get(context.Context, ServerVulnerabilityAssessmentsSettingKindName, *ServerVulnerabilityAssessmentsSettingsClientGetOptions) (ServerVulnerabilityAssessmentsSettingsClientGetResponse, error)` info [Changelog] - New function `*ServerVulnerabilityAssessmentsSettingsClient.NewListBySubscriptionPager(*ServerVulnerabilityAssessmentsSettingsClientListBySubscriptionOptions) *runtime.Pager[ServerVulnerabilityAssessmentsSettingsClientListBySubscriptionResponse]` info [Changelog] - New struct `ActionableRemediation` info [Changelog] - New struct `Authorization` info [Changelog] - New struct `AzureDevOpsOrg` info [Changelog] - New struct `AzureDevOpsOrgListResponse` info [Changelog] - New struct `AzureDevOpsOrgProperties` info [Changelog] - New struct `AzureDevOpsOrganizationConfiguration` info [Changelog] - New struct `AzureDevOpsProject` info [Changelog] - New struct `AzureDevOpsProjectConfiguration` info [Changelog] - New struct `AzureDevOpsProjectListResponse` info [Changelog] - New struct `AzureDevOpsProjectProperties` info [Changelog] - New struct `AzureDevOpsRepository` info [Changelog] - New struct `AzureDevOpsRepositoryListResponse` info [Changelog] - New struct `AzureDevOpsRepositoryProperties` info [Changelog] - New struct `AzureServersSetting` info [Changelog] - New struct `BaseResourceConfiguration` info [Changelog] - New struct `CategoryConfiguration` info [Changelog] - New struct `DefenderForStorageSetting` info [Changelog] - New struct `DefenderForStorageSettingProperties` info [Changelog] - New struct `DevOpsConfiguration` info [Changelog] - New struct `DevOpsConfigurationListResponse` info [Changelog] - New struct `DevOpsConfigurationProperties` info [Changelog] - New struct `ErrorDetailAutoGenerated2` info [Changelog] - New struct `ErrorResponseAutoGenerated2` info [Changelog] - New struct `GitHubOwner` info [Changelog] - New struct `GitHubOwnerConfiguration` info [Changelog] - New struct `GitHubOwnerListResponse` info [Changelog] - New struct `GitHubOwnerProperties` info [Changelog] - New struct `GitHubRepository` info [Changelog] - New struct `GitHubRepositoryListResponse` info [Changelog] - New struct `GitHubRepositoryProperties` info [Changelog] - New struct `GitLabGroup` info [Changelog] - New struct `GitLabGroupConfiguration` info [Changelog] - New struct `GitLabGroupListResponse` info [Changelog] - New struct `GitLabGroupProperties` info [Changelog] - New struct `GitLabProject` info [Changelog] - New struct `GitLabProjectListResponse` info [Changelog] - New struct `GitLabProjectProperties` info [Changelog] - New struct `MalwareScanningProperties` info [Changelog] - New struct `OnUploadProperties` info [Changelog] - New struct `OperationStatusAutoGenerated` info [Changelog] - New struct `OperationStatusResult` info [Changelog] - New struct `ProxyResource` info [Changelog] - New struct `ResourceAutoGenerated` info [Changelog] - New struct `ResourceAutoGenerated2` info [Changelog] - New struct `SensitiveDataDiscoveryProperties` info [Changelog] - New struct `ServerVulnerabilityAssessmentsAzureSettingProperties` info [Changelog] - New struct `ServerVulnerabilityAssessmentsSettingsList` info [Changelog] - New struct `TargetBranchConfiguration` info [Changelog] - New field `AffectedDefendersSubPlans`, `ReportAdditionalData` in struct `HealthReportProperties` info [Changelog] - New field `LastScannedDate`, `Reason` in struct `StatusAutoGenerated` info [Changelog] info [Changelog] Total 5 breaking change(s), 207 additive change(s).
️❌
azure-sdk-for-python-track2 failed [Detail]
❌
Code Generator Failed [Logs]Release - Generate from 64ffad1a3042017e07f8a47df17d6acaa2c1e609. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice cmdout [automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh warn Skip package processing as generation is failed
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 64ffad1a3042017e07f8a47df17d6acaa2c1e609. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️
@azure/arm-security [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Added Type Alias GovernanceRulesCreateOrUpdateResponse info [Changelog] - Added Type Alias GovernanceRulesExecuteResponse info [Changelog] - Added Type Alias GovernanceRulesGetResponse info [Changelog] - Added Type Alias GovernanceRulesListNextResponse info [Changelog] - Added Type Alias GovernanceRulesListResponse info [Changelog] - Added Type Alias GovernanceRulesOperationResultsResponse info [Changelog] - Added Type Alias GovernanceRuleSourceResourceType info [Changelog] - Added Type Alias GovernanceRuleType info [Changelog] - Added Type Alias HealthReportsGetResponse info [Changelog] - Added Type Alias HealthReportsListNextResponse info [Changelog] - Added Type Alias HealthReportsListResponse info [Changelog] - Added Type Alias InheritFromParentState info [Changelog] - Added Type Alias IsEnabled info [Changelog] - Added Type Alias MinimalSeverity info [Changelog] - Added Type Alias MipIntegrationStatus info [Changelog] - Added Type Alias OnboardingState info [Changelog] - Added Type Alias OperationResult info [Changelog] - Added Type Alias Roles info [Changelog] - Added Type Alias RuleCategory info [Changelog] - Added Type Alias ScanningMode info [Changelog] - Added Type Alias SecurityConnectorApplicationCreateOrUpdateResponse info [Changelog] - Added Type Alias SecurityConnectorApplicationGetResponse info [Changelog] - Added Type Alias SecurityConnectorApplicationsListNextResponse info [Changelog] - Added Type Alias SecurityConnectorApplicationsListResponse info [Changelog] - Added Type Alias SecurityOperatorsCreateOrUpdateResponse info [Changelog] - Added Type Alias SecurityOperatorsGetResponse info [Changelog] - Added Type Alias SecurityOperatorsListResponse info [Changelog] - Added Type Alias SensitivitySettingsListResponse info [Changelog] - Added Type Alias ServerVulnerabilityAssessmentsAzureSettingSelectedProvider info [Changelog] - Added Type Alias ServerVulnerabilityAssessmentsSettingKind info [Changelog] - Added Type Alias ServerVulnerabilityAssessmentsSettingKindName info [Changelog] - Added Type Alias ServerVulnerabilityAssessmentsSettingsCreateOrUpdateResponse info [Changelog] - Added Type Alias ServerVulnerabilityAssessmentsSettingsGetResponse info [Changelog] - Added Type Alias ServerVulnerabilityAssessmentsSettingsListBySubscriptionNextResponse info [Changelog] - Added Type Alias ServerVulnerabilityAssessmentsSettingsListBySubscriptionResponse info [Changelog] - Added Type Alias ServerVulnerabilityAssessmentsSettingUnion info [Changelog] - Added Type Alias SettingNameAutoGenerated info [Changelog] - Added Type Alias StatusName info [Changelog] - Added Type Alias SubPlan info [Changelog] - Added Type Alias Type info [Changelog] - Added Type Alias UpdateSensitivitySettingsResponse info [Changelog] - Interface AlertsSimulateOptionalParams has a new optional parameter resumeFrom info [Changelog] - Interface AlertsSimulateOptionalParams has a new optional parameter updateIntervalInMs info [Changelog] - Interface DefenderForServersAwsOfferingArcAutoProvisioning has a new optional parameter cloudRoleArn info [Changelog] - Interface DefenderForServersAwsOfferingArcAutoProvisioning has a new optional parameter configuration info [Changelog] - Interface ScanProperties has a new optional parameter lastScanTime info [Changelog] - Type of parameter offeringType of interface CloudOffering is changed from "CspmMonitorAws" | "DefenderForContainersAws" | "DefenderForServersAws" | "InformationProtectionAws" to "CspmMonitorAws" | "DefenderForContainersAws" | "DefenderForServersAws" | "DefenderForDatabasesAws" | "InformationProtectionAws" | "CspmMonitorGcp" | "DefenderForServersGcp" | "DefenderForDatabasesGcp" | "DefenderForContainersGcp" | "CspmMonitorGithub" | "CspmMonitorAzureDevOps" | "DefenderCspmAws" | "DefenderCspmGcp" | "DefenderForDevOpsGithub" | "DefenderForDevOpsAzureDevOps" | "CspmMonitorGitLab" | "DefenderForDevOpsGitLab" info [Changelog] - Added Enum KnownActionableRemediationState info [Changelog] - Added Enum KnownAnnotateDefaultBranchState info [Changelog] - Added Enum KnownApplicationConditionOperator info [Changelog] - Added Enum KnownApplicationSourceResourceType info [Changelog] - Added Enum KnownAutoDiscovery info [Changelog] - Added Enum KnownCode info [Changelog] - Added Enum KnownDesiredOnboardingState info [Changelog] - Added Enum KnownDevOpsProvisioningState info [Changelog] - Added Enum KnownEnvironmentType info [Changelog] - Added Enum KnownGovernanceRuleConditionOperator info [Changelog] - Added Enum KnownGovernanceRuleOwnerSourceType info [Changelog] - Added Enum KnownGovernanceRuleSourceResourceType info [Changelog] - Added Enum KnownGovernanceRuleType info [Changelog] - Added Enum KnownInheritFromParentState info [Changelog] - Added Enum KnownIsEnabled info [Changelog] - Added Enum KnownMinimalSeverity info [Changelog] - Added Enum KnownMipIntegrationStatus info [Changelog] - Added Enum KnownOnboardingState info [Changelog] - Added Enum KnownOperationResult info [Changelog] - Added Enum KnownRoles info [Changelog] - Added Enum KnownRuleCategory info [Changelog] - Added Enum KnownScanningMode info [Changelog] - Added Enum KnownServerVulnerabilityAssessmentsAzureSettingSelectedProvider info [Changelog] - Added Enum KnownServerVulnerabilityAssessmentsSettingKind info [Changelog] - Added Enum KnownServerVulnerabilityAssessmentsSettingKindName info [Changelog] - Added Enum KnownSettingNameAutoGenerated info [Changelog] - Added Enum KnownStatusName info [Changelog] - Added Enum KnownSubPlan info [Changelog] - Added Enum KnownType info [Changelog] - Enum KnownAlertStatus has a new value InProgress info [Changelog] - Enum KnownBundleType has a new value CosmosDbs info [Changelog] - Enum KnownCloudName has a new value AzureDevOps info [Changelog] - Enum KnownCloudName has a new value Github info [Changelog] - Enum KnownCloudName has a new value GitLab info [Changelog] - Enum KnownOfferingType has a new value CspmMonitorAzureDevOps info [Changelog] - Enum KnownOfferingType has a new value CspmMonitorGcp info [Changelog] - Enum KnownOfferingType has a new value CspmMonitorGithub info [Changelog] - Enum KnownOfferingType has a new value CspmMonitorGitLab info [Changelog] - Enum KnownOfferingType has a new value DefenderCspmAws info [Changelog] - Enum KnownOfferingType has a new value DefenderCspmGcp info [Changelog] - Enum KnownOfferingType has a new value DefenderForContainersGcp info [Changelog] - Enum KnownOfferingType has a new value DefenderForDatabasesAws info [Changelog] - Enum KnownOfferingType has a new value DefenderForDatabasesGcp info [Changelog] - Enum KnownOfferingType has a new value DefenderForDevOpsAzureDevOps info [Changelog] - Enum KnownOfferingType has a new value DefenderForDevOpsGithub info [Changelog] - Enum KnownOfferingType has a new value DefenderForDevOpsGitLab info [Changelog] - Enum KnownOfferingType has a new value DefenderForServersGcp info [Changelog] - Enum KnownSettingName has a new value WdatpUnifiedSolution info [Changelog] - Added function getContinuationToken info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Removed operation Alerts.simulate info [Changelog] - Removed operation SecurityContacts.update info [Changelog] - Operation AllowedConnections.get has a new signature info [Changelog] - Class SecurityCenter has a new signature info [Changelog] - Interface AlertsSuppressionRulesListNextOptionalParams no longer has parameter alertType info [Changelog] - Interface DefenderForServersAwsOfferingArcAutoProvisioning no longer has parameter servicePrincipalSecretMetadata info [Changelog] - Interface IotSecuritySolutionListByResourceGroupNextOptionalParams no longer has parameter filter info [Changelog] - Interface IotSecuritySolutionListBySubscriptionNextOptionalParams no longer has parameter filter info [Changelog] - Interface IotSecuritySolutionsAnalyticsAggregatedAlertListNextOptionalParams no longer has parameter top info [Changelog] - Interface IotSecuritySolutionsAnalyticsRecommendationListNextOptionalParams no longer has parameter top info [Changelog] - Interface RegulatoryComplianceAssessmentsListNextOptionalParams no longer has parameter filter info [Changelog] - Interface RegulatoryComplianceControlsListNextOptionalParams no longer has parameter filter info [Changelog] - Interface RegulatoryComplianceStandardsListNextOptionalParams no longer has parameter filter info [Changelog] - Interface SecureScoreControlsListBySecureScoreNextOptionalParams no longer has parameter expand info [Changelog] - Interface SecureScoreControlsListNextOptionalParams no longer has parameter expand info [Changelog] - Interface TasksListByHomeRegionNextOptionalParams no longer has parameter filter info [Changelog] - Interface TasksListByResourceGroupNextOptionalParams no longer has parameter filter info [Changelog] - Interface TasksListNextOptionalParams no longer has parameter filter info [Changelog] - Type of parameter value of interface ExternalSecuritySolutionList is changed from ExternalSecuritySolutionUnion[] to ExternalSecuritySolution[] info [Changelog] - Removed Enum KnownAlertNotifications info [Changelog] - Removed Enum KnownAlertsToAdmins
️⚠️
azure-sdk-for-java warning [Detail]
⚠️
Warning [Logs]Release - Generate from 64ffad1a3042017e07f8a47df17d6acaa2c1e609. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️
azure-resourcemanager-security [View full logs] [Release SDK Changes]
️❌
azure-resource-manager-schemas failed [Detail]
❌
Failed [Logs]Release - Generate from 64ffad1a3042017e07f8a47df17d6acaa2c1e609. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation
❌
security/resource-manager [View full logs]
️❌
azure-powershell failed [Detail]
❌
Pipeline Framework Failed [Logs]Release - Generate from 64ffad1a3042017e07f8a47df17d6acaa2c1e609. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️
Az.security.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.security.DefaultTag
Generated ApiView
Language | Package Name | ApiView Link |
---|---|---|
Go | sdk/resourcemanager/security/armsecurity | https://apiview.dev/Assemblies/Review/94a1fa093b59486885ce7eaaf4c131e6 |
Java | azure-resourcemanager-security | https://apiview.dev/Assemblies/Review/a6ec0089ac6744d18c9755cca71c730a |
.Net | Azure.ResourceManager.SecurityCenter | There is no API change compared with the previous version |
JavaScript | @azure/arm-security | https://apiview.dev/Assemblies/Review/ccb49662a9d24f7292c94e74efbb1d0a |
/azp run unifiedPipeline
No pipelines are associated with this pull request.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
Hi @ivadim! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff
.
Task | How to fix | Priority |
---|---|---|
Avocado | Fix-Avocado | High |
Semantic Validation | Fix-SemanticValidation-Error | High |
Model Validation | Fix-ModelValidation-Error | High |
LintDiff | Fix-LintDiff | High |
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.
/azp run unifiedPipeline
No pipelines are associated with this pull request.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@ms-henglu Thanks for your review. We have addressed your comments and finished tweaking our API. Please take another look and let us know if you have any further concerns.
@rkmanda looks like you are assigned to this. Can you please take a look at our latest Swagger? Thanks.
"x-ms-pageable": {
FYI, this extension doesn't do anything for POST actions. IOW, paging support is not generated in the SDK. It's not harmful to have it here, but it makes sense to remove it.
In reply to: 1619367336
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json:51 in fa2d657. [](commit_id = fa2d6570d8090220f405a745a5e6c1dba25c6c1a, deletion_comment = False)
"x-ms-pageable": {
Has no effect for POST actions. Comment applies to other POST actions in this file.
In reply to: 1619367409
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json:384 in fa2d657. [](commit_id = fa2d6570d8090220f405a745a5e6c1dba25c6c1a, deletion_comment = False)
"description": "Id of the GitHub app installation.",
Would be nice to mention the format (e.g. Uri, Guid,
In reply to: 1619367509
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json:3755 in fa2d657. [](commit_id = fa2d6570d8090220f405a745a5e6c1dba25c6c1a, deletion_comment = False)
@ivadim - Signed off for ARM with comments: please take a look.
"ghazdoState": {
Recommend only using very common acronyms/abbreviations (e.g. ip, pdf). Maybe githubAdvancedSecurityState...?
In reply to: 1622740911
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2023-09-01-preview/securityConnectorsDevOps.json:3146 in f6d35a2. [](commit_id = f6d35a28777bec8bd0feff91a1e4d60d3ba594e1, deletion_comment = False)
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested
label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query]
in the title of your question to indicate that it is ARM-related.
@ivadim - Left a comment, please take a look.
/azp run unifiedPipeline
No pipelines are associated with this pull request.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Hi, @ivadim. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity
label.