Chris Stackhouse

Results 194 comments of Chris Stackhouse

@ambrahma - This is a **huge** refactoring combined with adding a new API version. That makes it nearly impossible to review, since we have no way of knowing what's changed,...

> "/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/regionInfo": { This URI format specifies a collection of instances of the type regionInfo, so the response should be an array. If regionInfo doesn't actually behave like a resource...

> "/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/queryNetworkSiblingSet": { From looking at the definitions for these payloads, it seems like sibling set does behave more like an ARM resource type (has a name/id, has query and...

> "isAvailable": { Consider using enum instead of boolean, e.g. zoneAvailability: { available, unavailable } or similar. Generally enums are preferred over boolean for several reasons (ref: [https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html?q=boolean#common-issues-found-in-review](https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html?q=boolean#common-issues-found-in-review)). --- Refers...

@audunn - Looks like this PR got into my queue before WaitForARMReview was removed. I left some comments related to ARM review before noticing the label was gone. Please consider...

@pednekarpraj - You haven't filled out the submission form above. This is a hard requirement for reviewers and automation to help handle your PR correctly.

> @weidongxu-microsoft @mentat9 I filled the template. Can you help me merge this PR to our shared branch ? @pednekarpraj - Remove the ARMChangesRequested label to facilitate ARM review of...

> @mentat9, Is the Swagger SDK Breaking Change check required? Or is there a way to override it? @ehunter1878 - I don't know: that's in the purview of the Azure...

> @mentat9, why is the license/cla agreement not getting resolved? Am I not responding correctly? @ehunter1878 - Sorry, I don't know about that: looks OK to me. @leni-msft, any idea?

> > No i mean when when you do a customdomain/write you pass in the customcertificate , how do you ensure that the calling used has permissions on the customcertificate...