azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
[NetAppFiles ]Anf 18545 rotterdam phase2 2021 12 01 preview
The changes in this PR where reviewed on the private repo and synced with latest main here. This adds a new preview api version. https://github.com/Azure/azure-rest-api-specs-pr/pull/5709
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [x] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [ ] No refresh required for updates in this PR
Contribution checklist:
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [x] I have reviewed the documentation for the workflow.
- [x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
- [ ] Removing API(s) in a stable version
- [ ] Removing properties in a stable version
- [ ] Removing API version(s) in a stable version
- [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
- [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌LintDiff: 11 Errors, 3 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
| Rule | Message |
|---|---|
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3633 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3694 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3701 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3767 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L4098 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L4710 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L4810 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L5011 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L5313 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L6078 |
|
Missing identifier id in array item property Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L6607 |
| :warning: R1003 - ListInOperationName | Since operation 'NetAppResource_QueryRegionInfo' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L302 |
| :warning: R1005 - GetInOperationName | 'GET' operation 'NetAppResource_QueryRegionInfo' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L302 |
| :warning: R2029 - PageableOperation | Based on the response model schema, operation 'NetAppResource_QueryRegionInfo' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L296 |
The following errors/warnings exist before current PR submission:
Only 26 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.NetApp/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L40 |
|
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3630 |
|
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3650 |
|
The schema 'OperationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3682 |
|
The schema 'ServiceSpecification' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3691 |
|
The schema 'MetricSpecification' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3710 |
|
The schema 'Dimension' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3810 |
|
The schema 'exportPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L4706 |
|
The schema 'dataProtection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L4824 |
|
The schema 'exportPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L5309 |
|
The schema 'dataProtection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L5329 |
|
The schema 'cloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L6434 |
|
The schema 'cloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L6444 |
| :warning: R1005 - GetInOperationName | 'GET' operation 'Volumes_ReplicationStatus' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L1361 |
| :warning: R2029 - PageableOperation | Based on the response model schema, operation 'SnapshotPolicies_ListVolumes' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L2252 |
| :warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'capacityPools' with immediate parent 'netAppAccount', must have a list by immediate parent operation. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L4332 |
| :warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'volumes' with immediate parent 'capacityPool', must have a list by immediate parent operation. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L4584 |
| :warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'snapshots' with immediate parent 'volume', must have a list by immediate parent operation. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L5469 |
| :warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'snapshotPolicies' with immediate parent 'netAppAccount', must have a list by immediate parent operation. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L5581 |
| :warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'accountBackups' with immediate parent 'netAppAccount', must have a list by immediate parent operation. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L5904 |
| :warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'backups' with immediate parent 'volume', must have a list by immediate parent operation. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L5904 |
| :warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'backupPolicies' with immediate parent 'netAppAccount', must have a list by immediate parent operation. Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L6088 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: forceDelete Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L1205 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3755 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fillGapWithZero Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3778 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isInternal Location: Microsoft.NetApp/preview/2021-12-01-preview/netapp.json#L3790 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 2 Errors, 109 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:preview/2021-12-01-preview/netapp.json compared with base:stable/2021-10-01/netapp.json
- current:preview/2021-12-01-preview/netapp.json compared with base:preview/2021-04-01-preview/netapp.json
Only 26 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
Only 26 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go-track2 - armnetapp - 2.0.0❌azure-sdk-for-python-track2 - track2_azure-mgmt-netapp - 7.0.0+ Model VolumeGroup no longer has parameter tags + Model VolumeGroupDetails no longer has parameter tags
️✔️azure-sdk-for-go - netapp/mgmt/2021-10-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2021-08-01/netapp - v63.0.0❌azure-sdk-for-go - netapp/mgmt/2021-06-01/netapp - v63.0.0+ Field `Name` of struct `SubscriptionQuotaItemProperties` has been removed
️✔️azure-sdk-for-go - netapp/mgmt/2021-04-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2021-02-01/netapp - v63.0.0❌azure-sdk-for-go - netapp/mgmt/2020-12-01/netapp - v63.0.0+ Const `Auto` has been removed + Const `Manual` type has been changed from `QosType` to `BackupType` + Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
❌azure-sdk-for-go - netapp/mgmt/2020-11-01/netapp - v63.0.0+ Const `Auto` has been removed + Const `Manual` type has been changed from `QosType` to `BackupType` + Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
❌azure-sdk-for-go - netapp/mgmt/2020-09-01/netapp - v63.0.0+ Const `Auto` has been removed + Const `Manual` type has been changed from `QosType` to `BackupType` + Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
❌azure-sdk-for-go - netapp/mgmt/2020-08-01/netapp - v63.0.0+ Const `Auto` has been removed + Const `Manual` type has been changed from `QosType` to `BackupType` + Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
❌azure-sdk-for-go - netapp/mgmt/2020-07-01/netapp - v63.0.0+ Const `Auto` has been removed + Const `Manual` type has been changed from `QosType` to `BackupType` + Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
❌azure-sdk-for-go - netapp/mgmt/2020-06-01/netapp - v63.0.0+ Const `Auto` has been removed + Const `Manual` type has been changed from `QosType` to `BackupType` + Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
❌azure-sdk-for-go - netapp/mgmt/2020-05-01/netapp - v63.0.0+ Type of `BackupProperties.BackupType` has been changed from `*string` to `BackupType`
️✔️azure-sdk-for-go - netapp/mgmt/2020-03-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2020-02-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2019-11-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2019-10-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2019-08-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2019-07-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2019-06-01/netapp - v63.0.0️✔️azure-sdk-for-go - netapp/mgmt/2019-05-01/netapp - v63.0.0️✔️azure-sdk-for-go - preview/netapp/mgmt/2021-12-01-preview/netapp - v63.0.0️✔️azure-sdk-for-go - preview/netapp/mgmt/2021-04-01-preview/netapp - v63.0.0️✔️azure-sdk-for-go - preview/netapp/mgmt/2017-08-15/netapp - v63.0.0❌azure-sdk-for-js - @azure/arm-netapp - 16.0.0️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from e9843ac73411144f98df46d13a896bec14857afe. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.11.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.11.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-netapp [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation VolumesOperations.begin_finalize_relocation info [Changelog] - Added operation VolumesOperations.begin_relocate info [Changelog] - Added operation VolumesOperations.begin_reset_cifs_password info [Changelog] - Added operation VolumesOperations.begin_revert_relocation info [Changelog] - Added operation VolumesOperations.list_replications info [Changelog] - Added operation group VolumeQuotaRulesOperations info [Changelog] - Model ProxyResource has a new parameter system_data info [Changelog] - Model Resource has a new parameter system_data info [Changelog] - Model Volume has a new parameter encrypted info [Changelog] - Model Volume has a new parameter zones info [Changelog] - Model VolumeGroupVolumeProperties has a new parameter encrypted info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model VolumeGroup no longer has parameter tags info [Changelog] - Model VolumeGroupDetails no longer has parameter tags
️❌ azure-sdk-for-net failed [Detail]
❌Failed [Logs] Generate from e9843ac73411144f98df46d13a896bec14857afe. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] No usable version of the libssl was found cmderr [Autorest] FATAL: csharp/simplifier - FAILED cmderr [Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated. cmderr [Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated. error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest warn Skip package processing as generation is failed
️⚠️ azure-sdk-for-js warning [Detail]
⚠️Warning [Logs] Generate from e9843ac73411144f98df46d13a896bec14857afe. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json cmderr [automation_init.sh] WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist cmderr [automation_init.sh] deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. cmderr [automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js cmderr [automation_init.sh] WARN deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest cmderr [automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself. warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-netapp [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group VolumeQuotaRules info [Changelog] - Added operation Volumes.beginFinalizeRelocation info [Changelog] - Added operation Volumes.beginFinalizeRelocationAndWait info [Changelog] - Added operation Volumes.beginRelocate info [Changelog] - Added operation Volumes.beginRelocateAndWait info [Changelog] - Added operation Volumes.beginResetCifsPassword info [Changelog] - Added operation Volumes.beginResetCifsPasswordAndWait info [Changelog] - Added operation Volumes.beginRevertRelocation info [Changelog] - Added operation Volumes.beginRevertRelocationAndWait info [Changelog] - Added operation Volumes.listReplications info [Changelog] - Added Interface ListReplications info [Changelog] - Added Interface Replication info [Changelog] - Added Interface VolumeQuotaRulePatch info [Changelog] - Added Interface VolumeQuotaRulesCreateOptionalParams info [Changelog] - Added Interface VolumeQuotaRulesDeleteOptionalParams info [Changelog] - Added Interface VolumeQuotaRulesGetOptionalParams info [Changelog] - Added Interface VolumeQuotaRulesList info [Changelog] - Added Interface VolumeQuotaRulesListByVolumeOptionalParams info [Changelog] - Added Interface VolumeQuotaRulesUpdateOptionalParams info [Changelog] - Added Interface VolumeRelocationProperties info [Changelog] - Added Interface VolumesFinalizeRelocationOptionalParams info [Changelog] - Added Interface VolumesListReplicationsOptionalParams info [Changelog] - Added Interface VolumesRelocateOptionalParams info [Changelog] - Added Interface VolumesResetCifsPasswordOptionalParams info [Changelog] - Added Interface VolumesRevertRelocationOptionalParams info [Changelog] - Added Type Alias BackupPolicy info [Changelog] - Added Type Alias CapacityPool info [Changelog] - Added Type Alias EncryptionKeySource info [Changelog] - Added Type Alias NetAppAccount info [Changelog] - Added Type Alias ProvisioningState info [Changelog] - Added Type Alias SnapshotPolicy info [Changelog] - Added Type Alias TrackedResource info [Changelog] - Added Type Alias Type info [Changelog] - Added Type Alias Volume info [Changelog] - Added Type Alias VolumeQuotaRule info [Changelog] - Added Type Alias VolumeQuotaRulesCreateResponse info [Changelog] - Added Type Alias VolumeQuotaRulesGetResponse info [Changelog] - Added Type Alias VolumeQuotaRulesListByVolumeResponse info [Changelog] - Added Type Alias VolumeQuotaRulesUpdateResponse info [Changelog] - Added Type Alias VolumesListReplicationsResponse info [Changelog] - Interface Resource has a new optional parameter systemData info [Changelog] - Interface VolumeGroupVolumeProperties has a new optional parameter encrypted info [Changelog] - Class NetAppManagementClient has a new parameter volumeQuotaRules info [Changelog] - Added Enum KnownEncryptionKeySource info [Changelog] - Added Enum KnownType info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface VolumeGroup no longer has parameter tags info [Changelog] - Interface VolumeGroupDetails no longer has parameter tags info [Changelog] - Type Alias SubscriptionQuotaItem no longer has parameter systemData info [Changelog] - Type Alias SubvolumeInfo no longer has parameter systemData
️🔄 azure-sdk-for-go inProgress [Detail]
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from e9843ac73411144f98df46d13a896bec14857afe. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armnetapp [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `VolumeProperties.EncryptionKeySource` has been changed from `*string` to `*EncryptionKeySource` info [Changelog] - Field `Tags` of struct `VolumeGroupDetails` has been removed info [Changelog] - Field `Tags` of struct `VolumeGroup` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `TypeIndividualUserQuota` info [Changelog] - New const `ProvisioningStateSucceeded` info [Changelog] - New const `ProvisioningStateFailed` info [Changelog] - New const `TypeIndividualGroupQuota` info [Changelog] - New const `ProvisioningStateAccepted` info [Changelog] - New const `ProvisioningStateCreating` info [Changelog] - New const `ProvisioningStatePatching` info [Changelog] - New const `EncryptionKeySourceMicrosoftNetApp` info [Changelog] - New const `TypeDefaultGroupQuota` info [Changelog] - New const `TypeDefaultUserQuota` info [Changelog] - New const `ProvisioningStateDeleting` info [Changelog] - New const `ProvisioningStateMoving` info [Changelog] - New function `*VolumesClient.ListReplications(context.Context, string, string, string, string, *VolumesClientListReplicationsOptions) (VolumesClientListReplicationsResponse, error)` info [Changelog] - New function `*VolumesClient.BeginRevertRelocation(context.Context, string, string, string, string, *VolumesClientBeginRevertRelocationOptions) (*runtime.Poller[VolumesClientRevertRelocationResponse], error)` info [Changelog] - New function `*VolumesClient.BeginResetCifsPassword(context.Context, string, string, string, string, *VolumesClientBeginResetCifsPasswordOptions) (*runtime.Poller[VolumesClientResetCifsPasswordResponse], error)` info [Changelog] - New function `*VolumesClient.BeginFinalizeRelocation(context.Context, string, string, string, string, *VolumesClientBeginFinalizeRelocationOptions) (*runtime.Poller[VolumesClientFinalizeRelocationResponse], error)` info [Changelog] - New function `*VolumesClient.BeginRelocate(context.Context, string, string, string, string, *VolumesClientBeginRelocateOptions) (*runtime.Poller[VolumesClientRelocateResponse], error)` info [Changelog] - New function `PossibleTypeValues() []Type` info [Changelog] - New function `PossibleEncryptionKeySourceValues() []EncryptionKeySource` info [Changelog] - New function `PossibleProvisioningStateValues() []ProvisioningState` info [Changelog] - New struct `ListReplications` info [Changelog] - New struct `Replication` info [Changelog] - New struct `TrackedResource` info [Changelog] - New struct `VolumeQuotaRule` info [Changelog] - New struct `VolumeQuotaRulePatch` info [Changelog] - New struct `VolumeQuotaRulesClientBeginCreateOptions` info [Changelog] - New struct `VolumeQuotaRulesClientBeginDeleteOptions` info [Changelog] - New struct `VolumeQuotaRulesClientBeginUpdateOptions` info [Changelog] - New struct `VolumeQuotaRulesClientCreateResponse` info [Changelog] - New struct `VolumeQuotaRulesClientDeleteResponse` info [Changelog] - New struct `VolumeQuotaRulesClientGetOptions` info [Changelog] - New struct `VolumeQuotaRulesClientGetResponse` info [Changelog] - New struct `VolumeQuotaRulesClientListByVolumeOptions` info [Changelog] - New struct `VolumeQuotaRulesClientListByVolumeResponse` info [Changelog] - New struct `VolumeQuotaRulesClientUpdateResponse` info [Changelog] - New struct `VolumeQuotaRulesList` info [Changelog] - New struct `VolumeQuotaRulesProperties` info [Changelog] - New struct `VolumeRelocationProperties` info [Changelog] - New struct `VolumesClientBeginFinalizeRelocationOptions` info [Changelog] - New struct `VolumesClientBeginRelocateOptions` info [Changelog] - New struct `VolumesClientBeginResetCifsPasswordOptions` info [Changelog] - New struct `VolumesClientBeginRevertRelocationOptions` info [Changelog] - New struct `VolumesClientFinalizeRelocationResponse` info [Changelog] - New struct `VolumesClientListReplicationsOptions` info [Changelog] - New struct `VolumesClientListReplicationsResponse` info [Changelog] - New struct `VolumesClientRelocateResponse` info [Changelog] - New struct `VolumesClientResetCifsPasswordResponse` info [Changelog] - New struct `VolumesClientRevertRelocationResponse` info [Changelog] - New field `Zones` in struct `Volume` info [Changelog] - New field `SystemData` in struct `ProxyResource` info [Changelog] - New field `Encrypted` in struct `VolumeProperties` info [Changelog] - New field `SystemData` in struct `Resource` info [Changelog] info [Changelog] Total 3 breaking change(s), 80 additive change(s).
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from e9843ac73411144f98df46d13a896bec14857afe. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". cmderr [generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation cmderr [generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. cmderr [generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". cmderr [generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation cmderr [generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
️✔️azure-resourcemanager-netapp [View full logs] [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from e9843ac73411144f98df46d13a896bec14857afe. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️netapp [View full logs] [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
❌Failed [Logs] Generate from e9843ac73411144f98df46d13a896bec14857afe. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.netapp [View full logs] [Preview SDK Changes]
Hi @audunn, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
@raych1 can we get this PR moving the changes here are in a preview api version and where reviewed in the private repo. https://github.com/Azure/azure-rest-api-specs-pr/pull/5709
Hi, @audunn. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @audunn. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).
@audunn , next time please use the publish PR link to publish the PR reviewed in private repo so that the review here can be fast.
I saw this PR has 6 more file changes than the PR in private repo. What's that change?
Please also resolve the conflicts.
@raych1 did not know of this button thank you will use next time should make thinks simpler. Thank you.
"/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/regionInfo": {
This URI format specifies a collection of instances of the type regionInfo, so the response should be an array. If regionInfo doesn't actually behave like a resource type, you should consider using POST instead. If it does behave like a resource type, it should be modeled as named instances of the regionInfo resource type with the full complement of CRUD operations (GET/PUT/collection GET/DELETE/PATCH).
Refers to: specification/netapp/resource-manager/Microsoft.NetApp/preview/2021-12-01-preview/netapp.json:295 in 9be46d5. [](commit_id = 9be46d54bcb7f1ab5da845e5e34c9891d8984262, deletion_comment = False)
"/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/queryNetworkSiblingSet": {
From looking at the definitions for these payloads, it seems like sibling set does behave more like an ARM resource type (has a name/id, has query and update operations). Did you consider modeling as a resource type with standard ARM CRUD operations?
Refers to: specification/netapp/resource-manager/Microsoft.NetApp/preview/2021-12-01-preview/netapp.json:332 in 9be46d5. [](commit_id = 9be46d54bcb7f1ab5da845e5e34c9891d8984262, deletion_comment = False)
"isAvailable": {
Consider using enum instead of boolean, e.g. zoneAvailability: { available, unavailable } or similar. Generally enums are preferred over boolean for several reasons (ref: https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html?q=boolean#common-issues-found-in-review).
Refers to: specification/netapp/resource-manager/Microsoft.NetApp/preview/2021-12-01-preview/netapp.json:7009 in 9be46d5. [](commit_id = 9be46d54bcb7f1ab5da845e5e34c9891d8984262, deletion_comment = False)
@audunn - Looks like this PR got into my queue before WaitForARMReview was removed. I left some comments related to ARM review before noticing the label was gone. Please consider those comments in any subsequent PRs or updates.
@audunn , can you resolve conflicts and resolve the CI check errors(lintDiff)?
In addition, can you get breaking change review approval for the change of changing default value? see cross version breaking change errors.
Hi @audunn, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Hi, @audunn. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @audunn. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.