Milos Djermanovic

Results 651 comments of Milos Djermanovic

My thoughts: * There should be a command that runs all validations we have in a project (linting, unit tests, license check, etc.). `npm test` seems to me like the...

> ``` > "build": "ember build --environment=production", > "lint": "npm-run-all --aggregate-output --continue-on-error --parallel \"lint:!(fix)\"", > "lint:fix": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*:fix", > "lint:hbs": "ember-template-lint .", > "lint:hbs:fix": "ember-template-lint . --fix",...

> One more point, I like to ensure unused disable directive comments don't sneak in. Here are different ways to do that: > > 1. `"lint:js": "eslint --report-unused-disable-directives .",` >...

For `computed-property-spacing`, it makes the most sense to keep the current behavior and just document it (https://github.com/eslint/eslint/pull/14004 and https://github.com/eslint/eslint/pull/15423). and add tests (https://github.com/eslint/eslint/pull/15424).

Hi @Krinkle, thanks for the issue! > For the indent autofixer, when configured to use 2 spaces, to not leave code behind that fails to pass the rule, such as...

I think this is the same as https://github.com/eslint/eslint/issues/15509, just technically different node types, so I'll mark this as accepted too. I believe this will be included in https://github.com/eslint/eslint/pull/15555.

I wouldn't be opposed to adding this feature to the core if there are no alternatives. In my understanding, some plugin rules like [`eslint-comments/no-restricted-disable`](https://mysticatea.github.io/eslint-plugin-eslint-comments/rules/no-restricted-disable.html) provide the same functionality, but the...

> Disabling all inline config doesn’t seem like it solves the problem - some rules _should_ be disable-able with inline config; some should not. I agree with that, the solution...

> @mdjermanovic One concern with that workaround. How would it integrate into VSCode? I worry that people would disable a rule expecting it to pass PR build step. But then...