mwish
mwish
mentioned https://github.com/apache/arrow/issues/15058#issuecomment-1687558148 , do we need to remove that?
> It seems that parquet-mr does not use it yet. Can parquet-mr reads that?
🤔at least this patch is ok and seems other implementation has thrift, it doesn't break the standard..
Oh, Python lint failed...
I merged https://github.com/apache/parquet-testing/pull/49 , you can adjust the link here
Beside a Py Lint has failed: ``` Python Format............................................................Failed - hook id: flake8 - exit code: 1 python/pyarrow/tests/parquet/test_metadata.py:788:89: E501 line too long (97 > 88 characters) ```
@clee704 Sorry for delaying, I've update this patch myself. This patch LGTM and I'm willing to merge it before August 6th. Would you mind re-checking this?
Would check CPython build ``` Error compiling Cython file: ------------------------------------------------------------ ... return self.metadata.GetColumnIndexLocation().has_value() @property def metadata(self): """Additional metadata as key value pairs (dict[bytes, bytes]).""" wrapped = pyarrow_wrap_metadata(self.metadata.key_value_metadata()) ^ ------------------------------------------------------------ pyarrow/_parquet.pyx:514:18:...
@wgtmac @pitrou Do you have any more comments here? Lets move forward now
Would merge this week if no negative comments